Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support log4j2 contextSelector as AsyncLoggerContextSelector in gRPC log report #182

Merged
merged 1 commit into from
May 22, 2022

Conversation

andotorg
Copy link
Contributor

==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====

Fix apache/skywalking#9113
[✅] Fix the problem that traceid cannot be reported when log4j2 global is modified to asynchronous log
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ====

[✅] Update the CHANGES log.
[✅] Update the Log4j2 log.

….AsyncLoggerContextSelector` in gRPC log report.
@andotorg
Copy link
Contributor Author

image

image

@wu-sheng wu-sheng added enhancement New feature or request plugin labels May 22, 2022
@andotorg
Copy link
Contributor Author

@wu-sheng hi, I don't quite understand the reason for this failure. What should I do to solve this failed task?

@andotorg
Copy link
Contributor Author

Mark it #181

@wu-sheng
Copy link
Member

@wu-sheng hi, I don't quite understand the reason for this failure. What should I do to solve this failed task?

I just checked, I think this is not relative to you. https://logback.qos.ch/manual/appenders.html#AsyncAppender is in the doc, but somehow, qos.ch's CA fails(maybe expired).
You don't have to worry about this.

@wu-sheng wu-sheng added this to the 8.11.0 milestone May 22, 2022
@wu-sheng wu-sheng merged commit 5bc1d1d into apache:main May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants