set the getter/setter method name as a constant

Author: wang

apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/AbstractClassEnhancePluginDefine.java

@@ -51,6 +51,14 @@ public abstract class AbstractClassEnhancePluginDefine {
      * New field name.
      */
     public static final String CONTEXT_ATTR_NAME = "_$EnhancedClassField_ws";
+    /**
+     * Getter method name.
+     */
+    public static final String CONTEXT_GETTER_NAME = "getSkyWalkingDynamicField";
+    /**
+     * Setter method name.
+     */
+    public static final String CONTEXT_SETTER_NAME = "setSkyWalkingDynamicField";
 
     /**
      * Main entrance of enhancing the class.

apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/interceptor/enhance/ClassEnhancePluginDefine.java

@@ -103,9 +103,9 @@ protected DynamicType.Builder<?> enhanceInstance(TypeDescription typeDescription
                 newClassBuilder = newClassBuilder.defineField(
                     CONTEXT_ATTR_NAME, Object.class, ACC_PRIVATE | ACC_VOLATILE)
                                                  .implement(EnhancedInstance.class)
-                                                 .defineMethod("getSkyWalkingDynamicField", Object.class, Visibility.PUBLIC)
+                                                 .defineMethod(CONTEXT_GETTER_NAME, Object.class, Visibility.PUBLIC)
                                                  .intercept(FieldAccessor.ofField(CONTEXT_ATTR_NAME))
-                                                 .defineMethod("setSkyWalkingDynamicField", void.class, Visibility.PUBLIC).withParameters(Object.class)
+                                                 .defineMethod(CONTEXT_SETTER_NAME, void.class, Visibility.PUBLIC).withParameters(Object.class)
                                                  .intercept(FieldAccessor.ofField(CONTEXT_ATTR_NAME));
                 context.extendObjectCompleted();
             }

apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/interceptor/enhance/v2/ClassEnhancePluginDefineV2.java

@@ -136,9 +136,9 @@ protected DynamicType.Builder<?> enhanceInstance(TypeDescription typeDescription
                 newClassBuilder = newClassBuilder.defineField(
                     CONTEXT_ATTR_NAME, Object.class, ACC_PRIVATE | ACC_VOLATILE)
                                                  .implement(EnhancedInstance.class)
-                                                 .defineMethod("getSkyWalkingDynamicField", Object.class, Visibility.PUBLIC)
+                                                 .defineMethod(CONTEXT_GETTER_NAME, Object.class, Visibility.PUBLIC)
                                                  .intercept(FieldAccessor.ofField(CONTEXT_ATTR_NAME))
-                                                 .defineMethod("setSkyWalkingDynamicField", void.class, Visibility.PUBLIC).withParameters(Object.class)
+                                                 .defineMethod(CONTEXT_SETTER_NAME, void.class, Visibility.PUBLIC).withParameters(Object.class)
                                                  .intercept(FieldAccessor.ofField(CONTEXT_ATTR_NAME));
                 context.extendObjectCompleted();
             }

apm-sniffer/bytebuddy-patch/src/test/java/org/apache/skywalking/apm/agent/bytebuddy/cases/AbstractInterceptTest.java

@@ -60,6 +60,8 @@
 import static net.bytebuddy.jar.asm.Opcodes.ACC_PRIVATE;
 import static net.bytebuddy.jar.asm.Opcodes.ACC_VOLATILE;
 import static org.apache.skywalking.apm.agent.core.plugin.AbstractClassEnhancePluginDefine.CONTEXT_ATTR_NAME;
+import static org.apache.skywalking.apm.agent.core.plugin.AbstractClassEnhancePluginDefine.CONTEXT_GETTER_NAME;
+import static org.apache.skywalking.apm.agent.core.plugin.AbstractClassEnhancePluginDefine.CONTEXT_SETTER_NAME;
 
 public class AbstractInterceptTest {
     public static final String BIZ_FOO_CLASS_NAME = "org.apache.skywalking.apm.agent.bytebuddy.biz.BizFoo";
@@ -213,9 +215,9 @@ protected void installInterface(String className) {
                                 builder = builder.defineField(
                                                 CONTEXT_ATTR_NAME, Object.class, ACC_PRIVATE | ACC_VOLATILE)
                                         .implement(EnhancedInstance.class)
-                                        .defineMethod("getSkyWalkingDynamicField", Object.class, Visibility.PUBLIC)
+                                        .defineMethod(CONTEXT_GETTER_NAME, Object.class, Visibility.PUBLIC)
                                         .intercept(FieldAccessor.ofField(CONTEXT_ATTR_NAME))
-                                        .defineMethod("setSkyWalkingDynamicField", void.class, Visibility.PUBLIC).withParameters(Object.class)
+                                        .defineMethod(CONTEXT_SETTER_NAME, void.class, Visibility.PUBLIC).withParameters(Object.class)
                                         .intercept(FieldAccessor.ofField(CONTEXT_ATTR_NAME));
                             }
                             return builder;