Skip to content

Commit 88e0982

Browse files
authored
Merge pull request #17 from peachisai/uat
Fix
2 parents 8932f85 + a976175 commit 88e0982

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

apm-sniffer/bootstrap-plugins/jdk-httpclient-plugin/pom.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,7 @@
3232

3333
<properties>
3434
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
35-
<maven.compiler.source>11</maven.compiler.source>
36-
<maven.compiler.target>11</maven.compiler.target>
3735
<maven.compiler.release>11</maven.compiler.release>
38-
<compiler.version>11</compiler.version>
3936
</properties>
4037

4138
<build>

apm-sniffer/bootstrap-plugins/jdk-httpclient-plugin/src/main/java/org/apache/skywalking/apm/plugin/HttpClientSendAsyncInterceptor.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@
3232
import java.net.URI;
3333
import java.net.http.HttpRequest;
3434
import java.net.http.HttpResponse;
35+
import java.util.HashMap;
36+
import java.util.Map;
3537
import java.util.concurrent.CompletableFuture;
3638

3739
public class HttpClientSendAsyncInterceptor implements InstanceMethodsAroundInterceptor {
@@ -63,13 +65,14 @@ public Object afterMethod(EnhancedInstance objInst, Method method, Object[] allA
6365

6466
if (ret != null) {
6567
CompletableFuture<?> future = (CompletableFuture<?>) ret;
66-
future.whenComplete((response, throwable) -> {
68+
ret = future.whenComplete((response, throwable) -> {
6769
try {
6870
if (throwable != null) {
69-
Tags.HTTP_RESPONSE_STATUS_CODE.set(span, 500);
7071
span.errorOccurred();
7172
span.log(throwable);
72-
} else if (response instanceof HttpResponse) {
73+
return;
74+
}
75+
if (response instanceof HttpResponse) {
7376
HttpResponse<?> httpResponse = (HttpResponse<?>) response;
7477
int statusCode = httpResponse.statusCode();
7578
Tags.HTTP_RESPONSE_STATUS_CODE.set(span, statusCode);
@@ -82,7 +85,9 @@ public Object afterMethod(EnhancedInstance objInst, Method method, Object[] allA
8285
}
8386
});
8487
} else {
85-
Tags.HTTP_RESPONSE_STATUS_CODE.set(span, 404);
88+
Map<String, String> eventMap = new HashMap<String, String>();
89+
eventMap.put("error", "No response");
90+
span.log(System.currentTimeMillis(), eventMap);
8691
span.errorOccurred();
8792
}
8893
ContextManager.stopSpan();

0 commit comments

Comments
 (0)