Skip to content

Commit 4a89228

Browse files
committed
Fix
1 parent 71ab376 commit 4a89228

File tree

7 files changed

+77
-4
lines changed

7 files changed

+77
-4
lines changed
Lines changed: 70 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,70 @@
1+
# Licensed to the Apache Software Foundation (ASF) under one
2+
# or more contributor license agreements. See the NOTICE file
3+
# distributed with this work for additional information
4+
# regarding copyright ownership. The ASF licenses this file
5+
# to you under the Apache License, Version 2.0 (the
6+
# "License"); you may not use this file except in compliance
7+
# with the License. You may obtain a copy of the License at
8+
#
9+
# http://www.apache.org/licenses/LICENSE-2.0
10+
#
11+
# Unless required by applicable law or agreed to in writing, software
12+
# distributed under the License is distributed on an "AS IS" BASIS,
13+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
# See the License for the specific language governing permissions and
15+
# limitations under the License.
16+
17+
name: Test
18+
19+
on:
20+
pull_request:
21+
paths:
22+
- '.github/workflows/plugins-*.yaml'
23+
- 'apm-application-toolkit/**'
24+
- 'apm-commons/**'
25+
- 'apm-protocol/**'
26+
- 'apm-sniffer/**'
27+
- 'test/plugin/**'
28+
- '**/pom.xml'
29+
- '!**.md'
30+
31+
concurrency:
32+
group: plugins-jdk25-1-${{ github.event.pull_request.number || github.ref }}
33+
cancel-in-progress: true
34+
35+
jobs:
36+
build:
37+
name: Build
38+
runs-on: ubuntu-latest
39+
timeout-minutes: 30
40+
steps:
41+
- uses: actions/checkout@v2
42+
with:
43+
submodules: true
44+
- name: Build
45+
uses: ./.github/actions/build
46+
with:
47+
base_image_java: eclipse-temurin:25-jdk
48+
base_image_tomcat: tomcat:10.1-jdk25-temurin
49+
50+
test:
51+
needs: [ build ]
52+
name: ${{ matrix.case }}-jdk25
53+
runs-on: ubuntu-latest
54+
timeout-minutes: 90
55+
strategy:
56+
matrix:
57+
case:
58+
59+
steps:
60+
- uses: actions/checkout@v2
61+
with:
62+
submodules: true
63+
- uses: actions/setup-java@v2
64+
with:
65+
distribution: 'temurin'
66+
java-version: '25'
67+
- name: Run Test
68+
uses: ./.github/actions/run
69+
with:
70+
test_case: ${{ matrix.case }}

.github/workflows/publish-docker.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ jobs:
6464
timeout-minutes: 60
6565
strategy:
6666
matrix:
67-
java-version: [ 8, 11, 17, 21 ]
67+
java-version: [ 8, 11, 17, 21, 25 ]
6868
env:
6969
TAG: ${{ github.sha }}
7070
steps:

CHANGES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ Release Notes.
2222
* Fix Gateway 2.0.x plugin not activated for spring-cloud-starter-gateway 2.0.0.RELEASE.
2323
* Support kafka-clients-3.9.x intercept.
2424
* Upgrade kafka-clients version in optional-reporter-plugins to 3.9.1.
25+
* Bump up Lombok to v1.18.42 to adopt JDK25 compiling.
2526

2627
All issues and pull requests are [here](https://github.com/apache/skywalking/milestone/242?closed=1)
2728

Makefile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,15 @@ dist: build
3434

3535
# Docker build
3636

37-
base.all := alpine java8 java11 java17 java21
37+
base.all := alpine java8 java11 java17 java21 java25
3838
base.each = $(word 1, $@)
3939

4040
base.image.alpine := alpine:3
4141
base.image.java8 := eclipse-temurin:8-jre
4242
base.image.java11 := eclipse-temurin:11-jre
4343
base.image.java17 := eclipse-temurin:17-jre
4444
base.image.java21 := eclipse-temurin:21-jre
45+
base.image.java25 := eclipse-temurin:25-jre
4546

4647
docker.%: PLATFORMS =
4748
docker.%: LOAD_OR_PUSH = --load

docs/en/contribution/compiling.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Compiling project
22
This document will help you compile and build a project in your maven and set your IDE.
33

4-
Prepare JDK 17 or 21.
4+
Prepare JDK 17, 21 or 25.
55

66
* If you clone codes from https://github.com/apache/skywalking-java
77
```shell

docs/en/setup/service-agent/java-agent/Plugin-test.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -682,6 +682,7 @@ You can run `python3 tools/select-group.py` to see which file contains the least
682682

683683
If a test case required to run in JDK 17 environment, please add you test case into file `plugins-jdk17-test.<n>.yaml`.
684684
If a test case required to run in JDK 21 environment, please add you test case into file `plugins-jdk21-test.<n>.yaml`.
685+
If a test case required to run in JDK 25 environment, please add you test case into file `plugins-jdk25-test.<n>.yaml`.
685686

686687
```yaml
687688
jobs:

docs/en/setup/service-agent/java-agent/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Setup java agent
22

3-
1. Agent is available for JDK 8 - 21.
3+
1. Agent is available for JDK 8 - 25.
44
1. Find `agent` folder in SkyWalking release package
55
1. Set `agent.service_name` in `config/agent.config`. Could be any String in English.
66
1. Set `collector.backend_service` in `config/agent.config`. Default point to `127.0.0.1:11800`, only works for local

0 commit comments

Comments
 (0)