Commit 55d54fe
authored
Document the
apache/skywalking#13969 brings native meter (MeterReportService) rules to
parity with otel-rules: they now load through the shared Rules pipeline, so a
meter rule can be hot-added, overridden or inactivated at runtime and attached
to a MAL DSL debug session. On the wire that is purely additive — one more
value in the shared `Catalog` enum (`METER_ANALYZER_CONFIG`). No new endpoints,
no new request or response fields.
swctl therefore needs no functional change: `--catalog` is passed through
verbatim, and pkg/admin/runtimerule only ever calls the canonical
`/runtime/rule/...` routes, never the per-catalog shortcut routes that
`meter-analyzer-config` deliberately lacks. The OAP-side e2e added in that
commit already drives the whole flow (bundled / add / edit / dsl-debug /
inactivate) through `swctl admin ...` against this catalog.
What was stale was discoverability, so:
- add `meter-analyzer-config` to the `--catalog` flag help of
`admin runtime-rule` and `admin dsl-debug session start`, and to the
`admin runtime-rule` catalog list.
- drop the two unreferenced `Catalogs` vars in pkg/admin/{runtimerule,dsldebug}.
Nothing read them — they were a second copy of the catalog list, free to
drift out of sync with OAP's enum, and this change is exactly the drift they
would have caused. The rendered help text is now the single place the list
lives; widening it is not a client-side allow-list, so a newer OAP catalog
keeps working without a CLI release.meter-analyzer-config catalog in admin runtime-rule / dsl-debug (#233)1 parent 85e5afd commit 55d54fe
5 files changed
Lines changed: 4 additions & 9 deletions
File tree
- internal/commands/admin
- dsldebug
- runtimerule
- pkg/admin
- dsldebug
- runtimerule
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
| 89 | + | |
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
| 54 | + | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | 39 | | |
43 | 40 | | |
44 | 41 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | 34 | | |
38 | 35 | | |
39 | 36 | | |
| |||
0 commit comments