fix: correct logic for the log pagination #515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes the log pagination logic to address issue #13646. The changes correct the pagination calculation to properly determine when there are more pages available and introduce a centralized page size constant.
- Inverted the pagination total calculation logic to correctly show when more pages exist
- Introduced a
displayLogscomputed property to control which logs are displayed in the table - Centralized the page size default value (changed from 15 to 21) using a
PageSizeDefaultconstant
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/views/dashboard/related/log/List.vue | Updated pagination logic by inverting the total calculation condition, added displayLogs computed property, and switched to using PageSizeDefault constant |
| src/store/modules/log.ts | Introduced PageSizeDefault constant (value 21) and updated initial paging configuration to use this constant |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wu-sheng
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apache/skywalking#13646