Skip to content

Conversation

@bmarwell
Copy link
Contributor

@bmarwell bmarwell commented May 9, 2020

  • Enables building with JDK11 and 14
  • refactored ServiceLoader loading into separate method to enable mocking.

  - Enables building with JDK11 and 14
  - refactored ServiceLoader loading into separate method to enable mocking.
@fpapon fpapon self-requested a review May 9, 2020 12:24
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
LGTM

@fpapon fpapon merged commit 930380c into apache:master May 9, 2020
@bmarwell bmarwell deleted the SHIRO-772-powermock branch May 9, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants