[3.0] Integration Testing and samples issues

[lprimak]

Hi,

As you may know, I have been working on getting Shiro 3.x in better shape.
It's going pretty well, but I am getting stuck on the "servlet container" integration tests.

Currently, we have a few different types of integration tests:

Full Jakarta EE Containers:

• Payara (Jakarta EE) tests
• OpenLiberty (Jax-RS and CDI) tests

The Full Jakarta EE containers are now working perfectly in 3.x, and did not have any significant issues / hurdles.

However, the "servlet container" integration tests are giving me all sorts of troubles.
Here are the ones that I can see so far:

• Jetty + https://github.com/mjeanroy/junit-servers
• Tomcat + Meecrowave

So far, only Tomcat + Meecrowave ITs are working properly, but those tests are the minority

Jetty tests are giving me the most trouble.
junit-servers module isn't compatible (yet?) with Jakarta EE 11, which is problem 1.
I filed a bug mjeanroy/junit-servers#964

Jetty itself is hard to deal with, all the changing GAV names and all sorts of dependencies that need to be manually managed (or is there a better way?)

Should we remove Jetty and just use Tomcat+Meecrowave everywhere?
What about Spring / SpringBoot and Guice tests? Do they need Jetty or can they use Meecrowave?
Should we leave Jetty and get things fixed somehow?

What do you think?

[fpapon]

I think we can just keep the Tomcat container as it's also use in spring boot.

[lprimak]

Does that mean we need to drop Meecrowave? Or should we stick with Tomcat + Meecrowave?

[rmannibucau]

my 2cts would be that fusion-http-server can be a lighter server than meecrowave for CDI-less tests - but still neat as surfacing API for Tomcat - and meecrowave is good for CDI layer.
no real need of abstraction IMHO since coverage would be different/overlapping/complementary indirectly.

[lprimak]

Looks like mjeanroy/junit-servers#964 has been updated by Mickael (maintainer) and hopefully this will be resolved by him