Add AUTHORS & Script auto AUTHORS generate_authors#1895
Add AUTHORS & Script auto AUTHORS generate_authors#1895BDadmehr0 wants to merge 8 commits intoapache:masterfrom
Conversation
jbampton
left a comment
There was a problem hiding this comment.
You should remove all the unneeded code comments
jbampton
left a comment
There was a problem hiding this comment.
Seems that some entries are duplicated
Perhaps a groupby / merge is missing for commit author ??
jbampton
left a comment
There was a problem hiding this comment.
If you run pre-commit locally it will help format your files to be compliant.
Otherwise you can run "black" on your Python files.
And make sure there is no trailing whitespace in the Authors file.
You can see these issues in the pre-commit failure workflow.
run black and remove comments list with user's usernames
|
fixed @jbampton |
jbampton
left a comment
There was a problem hiding this comment.
We have to decide what to do with the new bandit issues shown in the pre-commit failure workflow
|
It seems the commit totals are not 100% correct. @AmirTallap would you like to review this PR ? Is there an easier way to do this ? |
- Using `shutil.which("git")`: Resolves **B607** (partial executable path)
- Checking for the existence of `git` and handling errors: Increases security and prevents crashes
- Error handling in `subprocess.check_output`: Addresses **B603** and follows better security practices
- Keeping `subprocess` usage only with safe paths and hardcoded arguments: Fully resolves **B603**, **B607**, and **B404**
jbampton
left a comment
There was a problem hiding this comment.
We should not store the Python script in the repo root. We try to minimize the amount of files in the root.
There is a tools folder perhaps we should make a sub directory there called scripts so it would be tools/scripts.
Is there a better location ?
Checking! |
Fix recoverable subprocess errors and silence unrecoverable ones
|
I fixed all the Bandit errors that were resolvable, but Bandit raises default security warnings for subprocess (B603 and B404), which don't have alternative solutions, so we need to silence them. @jbampton Bandit output |
|
Hey @BDadmehr0 thanks for all of this. Pretty sure the commit totals are not correct for some contributors |
Hello, sorry for the delay. I've improved my script, but I need to make sure the current script isn't working correctly. If you're referring to the file https://github.com/apache/sedona/pull/1895/files#diff-ab6af77435f58cc0c9d4c31dfe05656e45187cc7c7fc02aada401a7642125463, I should mention that this script needs to be run in a cloned environment of https://github.com/apache/sedona/ on the main branch that has been recently updated to correctly show the commits. Please test this and let me know. |
|
Why do I want this? Because my improved script also doesn't fetch the latest commits in my cloned branch. @jbampton |
@jbampton
AUTHORS file look like mruby/AUTHORS