Skip to content

Conversation

@dbgp2021
Copy link

@dbgp2021 dbgp2021 commented Mar 30, 2021

… potential garbled problems

Issues: When a InputStreamReader is used, the parameter setting of a default character set is recommended to solve potential garbled problems.

Changes: Set a default character set in InputStreamReader API.

Tests: No tests. TODO.

@mynameborat
Copy link
Contributor

Can you please update the description following the guideline?

@dbgp2021
Copy link
Author

dbgp2021 commented Apr 7, 2021

@mynameborat Thanks for the reminder! The description has been added now.

@mynameborat
Copy link
Contributor

@mynameborat Thanks for the reminder! The description has been added now.

Thank you! It will be useful to describe the scenario where this is problematic and provide some context on the background of the issue. The description right now talks about solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants