Skip to content

Conversation

ifplusor
Copy link
Contributor

@ifplusor ifplusor commented Jul 8, 2019

What is the purpose of the change

do some optimization in transport layer

Brief changelog

  1. optimize lock-wait by double-check when waitTcpConnectEvent.
  2. always addTimerCallback in invokeAsync for avoid memory leak when pass NULL cbw and not response.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@ifplusor ifplusor force-pushed the optimize-transport branch from cdf7136 to f9a1524 Compare July 12, 2019 01:19
@ifplusor ifplusor force-pushed the optimize-transport branch 5 times, most recently from a52e56e to 1a6fcab Compare August 2, 2019 10:20
@ifplusor ifplusor force-pushed the optimize-transport branch from 1a6fcab to efba7a7 Compare August 26, 2019 05:35
@ShannonDing ShannonDing added the bug Something isn't working label Nov 11, 2019
@ShannonDing ShannonDing added this to the 1.2.4 milestone Nov 11, 2019
@ShannonDing ShannonDing merged commit ce126b7 into apache:master Nov 11, 2019
@ifplusor ifplusor deleted the optimize-transport branch December 31, 2019 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants