RATIS-1291. Send heartbeat when there is no reply #398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, when there always exist log, leader only send log, and will not send heartbeat. The problem is if follower need a
long time to process log, leader maybe receives response from follower after a long time.
In this pr, I record lastRpcSendTimeWithResponse, i.e. when leader receive response of request1, leader record the send time of request1. Besides, I record lastHeartBeatSendTime, i.e. the send time of heartbeat.
Use this two timestamp, leader send heartbeat when can not receive response after minRpcTimeoutMs()/2. If log cost a
short time from request to reply, leader also does not need to send heartbeat.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1291
How was this patch tested?
no need new ut