RATIS-2371. Fix LeaderElection/SegmentedRaftLogReader/FileChunkReader CT_CONSTRUCTOR_THROW spotbugs #1327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OneSizeFitsQuorum
changed the title
adoroszlai
reviewed
Dec 13, 2025
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @OneSizeFitsQuorum for the patch.
ratis-server/src/main/java/org/apache/ratis/server/impl/LeaderElection.java
Outdated
Show resolved
Hide resolved
Signed-off-by: OneSizeFitsQuorum <tanxinyu@apache.org>
adoroszlai
reviewed
Dec 14, 2025
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @OneSizeFitsQuorum for updating the patch.
ratis-server/src/main/java/org/apache/ratis/server/impl/LeaderElection.java
Outdated
Show resolved
Hide resolved
Signed-off-by: OneSizeFitsQuorum <tanxinyu@apache.org>
adoroszlai
approved these changes
Dec 14, 2025
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @OneSizeFitsQuorum for updating the patch, LGTM.
Contributor
|
@szetszwo would you like to take a look? |
szetszwo
approved these changes
Dec 15, 2025
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
@OneSizeFitsQuorum , thanks for working on this!
+1 the change looks good. Just saw an indentation problem.
ratis-server/src/main/java/org/apache/ratis/server/impl/LeaderElection.java
Outdated
Show resolved
Hide resolved
Signed-off-by: OneSizeFitsQuorum <tanxinyu@apache.org>
Contributor
Author
|
Thanks a lot for reviewing this pr! @adoroszlai @szetszwo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title said