Skip to content

RATIS-2171. Safer initialization of TransactionContext#logIndexFuture #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 229 commits into
base: master
Choose a base branch
from
Open

RATIS-2171. Safer initialization of TransactionContext#logIndexFuture #1262

wants to merge 229 commits into from

Conversation

jianghuazhu
Copy link
Contributor

What changes were proposed in this pull request?

The purpose of this pr is to initialize TransactionContext#logIndexFuture() more safely.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/RATIS-2171

How was this patch tested?

ci:
https://github.com/jianghuazhu/ratis/actions/runs/15035520561

duongkame and others added 30 commits January 12, 2024 19:00
@duongkame
RATIS-1925. Support Zero-Copy in GrpcClientProtocolService (apache#1007)
84285d3
@ivandika3
RATIS-1998. Add watch request metrics (apache#1009)
59dfd35
@adoroszlai
RATIS-1989. Intermittent timeout in TestStreamObserverWithTimeout (ap…
2062058 
…ache#1012)
@szetszwo
RATIS-1987. Intermittent NPE in TestGrpcZeroCopy. (apache#1013)
863c2e8
@szetszwo
RATIS-1999. Move RaftServerJmxAdapter out from RaftServerImpl. (apach…
6671ef6 
…e#1010)
@szetszwo
RATIS-2001. TransactionContext can be wrongly reused. (apache#1015)
2448256
@adoroszlai
RATIS-2005. Fix URF_UNREAD_FIELD in MetricServerCallListener (apache#…
eae0d18 
…1018)
@adoroszlai
RATIS-2006. Fix DM_EXIT in filestore Client (apache#1019)
859a410
@adoroszlai
RATIS-2002. Fix findbugs warnings in LogSegmentPath (apache#1017)
14eb0bf
@duongkame
RATIS-1990. Refactor appendEntries processing to support reference co…
5d4ec69 
…unt (apache#1011)
@adoroszlai
RATIS-2003. Fix IT_NO_SUCH_ELEMENT in InstallSnapshotRequests (apache…
82f7b3b 
…#1016)
@adoroszlai
RATIS-2004. Fix EQ_COMPARETO_USE_OBJECT_EQUALS in LogSegment (apache#…
fc5c725 
…1020)
@duongkame
RATIS-2009. ReferenceCount should work for all LogEntry types. (apach…
82c31ea 
…e#1021)
@duongkame
RATIS-1934. Support Zero-Copy in GrpcServerProtocolService (apache#1014)
d459eb6
@adoroszlai
RATIS-2010. Remove dependency on spotbugs-annotations (apache#1022)
561cd6d
@szetszwo
RATIS-2013. OrderedAsync retry results an IllegalStateException in Gr…
c1e0ec2 
…pcClientProtocolService. (apache#1026)
@nandakumar131
RATIS-1972. Add junit 5 dependencies in ratis-server. (apache#1003)
0e24757
@szetszwo
RATIS-2012. Client should not retry after close. (apache#1025)
ea1341b
@ivandika3
RATIS-2008. Follower should recognize candidate if the candidate is t…
79923c2 
…he same peer as the current valid leader (apache#1024)
@duongkame
RATIS-2007. Zero-copy buffers are not released (apache#1027)
e2aaddc
@adoroszlai
RATIS-2015. Node.js 16 actions are deprecated (apache#1028)
a18d08c
@szetszwo
RATIS-2011. When a log entry is truncated, remove TransactionContext. (…
5560718 
…apache#1029)
@duongkame
RATIS-2017: checkAndEvictCache must be done in writeLock. (apache#1031)
7d587ec
@symious
RATIS-2016. Correct NotificationInstallSnapshot's index (apache#1030)
035cd96
@nandakumar131
RATIS-1974. Migrate ratis-metrics-default tests to Junit 5 (apache#1034)
9cd74a2
@duongkame
RATIS-2018. Zero-copy buffers are not released - 2nd chunk (apache#1032)
c4b10fa
@nandakumar131
RATIS-1973. Migrate ratis-examples tests to Junit 5. (apache#1035)
cf897f0
@OneSizeFitsQuorum
RATIS-2019 Fixed abnormal exit of StateMachineUpdater (apache#1033)
d2f1c57
@duongkame
RATIS-1978. Add tests assertions to verify all zero-copy messages are…
c46da22 
… released properly (apache#1023)
@nandakumar131
RATIS-1975. Migrate ratis-metrics-dropwizard3 tests to Junit 5. (apac…
a2cb49e 
…he#1037)
slfan1989 and others added 27 commits March 4, 2025 10:51
@slfan1989
RATIS-2124. Remove the use of org.junit.Rule. (apache#1232)
0091c1c
@szetszwo
RATIS-2256. Update Maven to 3.9.9 (apache#1234)
09ff1e1
@szetszwo
RATIS-2255. Migrate ratis-grpc to junit 5. (apache#1233)
d740e51
@adoroszlai
RATIS-2261. Mark TestRaftSnapshotWithGrpc as flaky
fab8a92
@adoroszlai
RATIS-2262. Mark RaftBasicTests#testStateMachineMetrics as flaky
3947cf3
@adoroszlai
RATIS-2260. AtomicFileOutputStream should truncate temp file (apache#…
0bc5aad 
…1237)
@adoroszlai
RATIS-2263. Bump sonar-maven-plugin to 5.0.0.4389 (apache#1238)
f00d764
@szetszwo
RATIS-2258. Caching TermIndex objects (apache#1239)
ac35188
@szetszwo
RATIS-2266. Use WeakValueCache instead of Guava cache in RaftId. (apa…
7723c2b 
…che#1240)
@hfutatzhanghb
RATIS-2268. A minor documatention fix for method getSuccessors. (apac…
93ab53c 
…he#1242)
@hfutatzhanghb
RATIS-2269. Remove all import java.util.* statements. (apache#1243)
72c1765
@adoroszlai
RATIS-2209. Exercise make_rc.sh in CI (apache#1244)
0fd4b3a
@RkGrit
RATIS-2271 Leadership Loss Causes ClosedByInterruptException and Null…
688bbae 
…PointerException in LogAppender Thread (apache#1245)
@RkGrit
RATIS-2274. Newly added peer may retain outdated configuration after …
7be7cb8 
…membership change, causing election failure. (apache#1246)
@RkGrit
RATIS-2278. Follower Fails to Append Entries Due to Index Validation …
f5e9935 
…in NavigableIndices (apache#1247)
@szetszwo
Revert "RATIS-2278. Follower Fails to Append Entries Due to Index Val…
ca81a21 
…idation in NavigableIndices (apache#1247)"

This reverts commit f5e9935.
@RkGrit
RATIS-2282. LogAppender Restart Due to Premature Log Entry Access Dur…
de58f05 
…ing Concurrent Write Processing (apache#1249)
@RkGrit
RATIS-2278. Follower Fails to Append Entries Due to Index Validation …
8ab57e1 
…Race Condition in NavigableIndices (apache#1248)
@RkGrit
RATIS-2283. GrpcLogAppender Thread Restart Leaves catchup=false, Bloc…
3247c7f 
…king Reconfiguration Progress (apache#1250)
@adoroszlai
RATIS-2285. Bump ratis-thirdparty to 1.0.9 (apache#1252)
c36dac0
@jianghuazhu
RATIS-2286. Generate the necessary unified names for the submodules u…
d637a93 
…nder RaftServerImpl (apache#1251)
@jianghuazhu
RATIS-2287. Improve RaftServerImpl#toString() to make it more readable (
3babac3 
apache#1253)
@adoroszlai
RATIS-2289. Coverage is 0% due to no execution data files provided (a…
7f85d46 
…pache#1255)
@jianghuazhu
RATIS-2180. Use Objects.requireNonNull instead of Preconditions.asser…
21f9e5b 
…tNotNull (apache#1256)
@slfan1989
RATIS-2291. Fix failing TestInstallSnapshotNotificationWithGrpc#testA…
b0f5330 
…ddNewFollowersNoSnapshot. (apache#1257)
@jianghuazhu
RATIS-2290. Simply the EventQueue in leader (apache#1258)
282d7a1
@jianghuazhu
RATIS-2171. Safer initialization of TransactionContext#logIndexFuture
31b2fe4
@adoroszlai adoroszlai requested a review from szetszwo May 18, 2025 13:37
@jianghuazhu
Copy link
Contributor Author

Could you please review this PR, @szetszwo ?
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szetszwo szetszwo Awaiting requested review from szetszwo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.