Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tiered storage] Replace usage of shaded Guava Supplier with java.util.function.Supplier #9693

Merged
merged 1 commit into from
Feb 25, 2021
Merged

[Tiered storage] Replace usage of shaded Guava Supplier with java.util.function.Supplier #9693

merged 1 commit into from
Feb 25, 2021

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Feb 24, 2021

Motivation

Modifications

  • Replace the usage of the shaded Guava Supplier with java.util.function.Supplier.
    • This is also instructed in the javadoc of Guava's Supplier:
      • "As this interface extends java.util.function.Supplier, an instance of this type can be used as a java.util.function.Supplier directly. To use a java.util.function.Supplier in a context where a com.google.common.base.Supplier is needed, use supplier::get."

@lhotari
Replace usage of shaded Guava Supplier with java.util.function.Supplier
494c826 
- it is a bad practice to reference shaded classes in other modules.
- in this case, it is possible to replace the usage of the shaded
  Guava Supplier with java.util.function.Supplier
@lhotari
Copy link
Member Author

lhotari commented Feb 24, 2021

/pulsarbot run-failure-checks

eolivelli
eolivelli approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari
Copy link
Member Author

lhotari commented Feb 24, 2021

/pulsarbot run-failure-checks

@sijie sijie added this to the 2.8.0 milestone Feb 24, 2021
@sijie sijie added the type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use label Feb 24, 2021
@lhotari
Copy link
Member Author

lhotari commented Feb 25, 2021

/pulsarbot run-failure-checks

2 similar comments
@lhotari
Copy link
Member Author

lhotari commented Feb 25, 2021

/pulsarbot run-failure-checks

@lhotari
Copy link
Member Author

lhotari commented Feb 25, 2021

/pulsarbot run-failure-checks

@merlimat merlimat merged commit f42f625 into apache:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@sijie sijie sijie approved these changes

@eolivelli eolivelli eolivelli approved these changes

Assignees

@lhotari lhotari

Labels
type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lhotari @merlimat @sijie @eolivelli