[issue #3975] Bugfix NPE on non durable consumer #3988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovelle
commented
Apr 5, 2019
| @@ -193,6 +193,7 @@ | |||
| * @return the new NonDurableCursor | |||
| */ | |||
| ManagedCursor newNonDurableCursor(Position startCursorPosition) throws ManagedLedgerException; | |||
| ManagedCursor newNonDurableCursor(Position startPosition, String subscriptionName) throws ManagedLedgerException; | |||
There was a problem hiding this comment.
I think that the correct action here would be to modify existing newNonDurableCursor instead of adding a new one, but I did that way in order to leave this change as easy as possible, please let me know what you think.
|
Hi @ConcurrencyPractitioner please take a look at this pull, you might face this issue adding tests on #3983 to |
lovelle
force-pushed
the
bugfix/npe_on_non_durable_consumer
branch
from
bc74097 to
3a879ab
Compare
*Motivation* Trying to fix apache#3975 When a reset of a cursor is performed with some timestamp on a non-durable consumer the message finder will fail with null pointer exception due to `cursor.getName()` being null. *Modifications* - Add method overloading for `newNonDurableCursor()` with subscription name. - Fix method getNonDurableSubscription to call `newNonDurableCursor()` with proper subscription name - Add test to assert issue.
lovelle
force-pushed
the
bugfix/npe_on_non_durable_consumer
branch
from
3a879ab to
1434b02
Compare
sijie
approved these changes
Apr 8, 2019
|
run integration tests |
merlimat
pushed a commit
that referenced
this pull request
May 19, 2019
*Motivation* Trying to fix #3975 When a reset of a cursor is performed with some timestamp on a non-durable consumer the message finder will fail with null pointer exception due to `cursor.getName()` being null. *Modifications* - Add method overloading for `newNonDurableCursor()` with subscription name. - Fix method getNonDurableSubscription to call `newNonDurableCursor()` with proper subscription name - Add test to assert issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Trying to fix #3975
When a reset of a cursor is performed with some timestamp on a non-durable
consumer the message finder will fail with null pointer exception due to
cursor.getName()being null.Modifications
newNonDurableCursor()with subscription name.newNonDurableCursor()withproper subscription name
Verifying this change