[fix][test] Fix ReplicatorRateLimiterTest

[Demogorgon314]

Motivation

The ReplicatorRateLimiterTest will always fail with StackOverflowError , because in #23322 the getRateLimiter always recursive call to itself.

ReplicatorRateLimiterTest.testReplicatorRateLimiterMessageNotReceivedAllMessages
java.lang.StackOverflowError
at org.apache.pulsar.broker.service.ReplicatorRateLimiterTest.getRateLimiter(ReplicatorRateLimiterTest.java:614)

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

[BewareMyPower]

It seems that this failed test was not detected by CI. At least it was not exposed in the latest PR:

We'd better ensure this test failure can be detected by CI, even if it's not required.

@lhotari Do you have any idea?

[lhotari]

It seems that this failed test was not detected by CI.

@BewareMyPower the test is in the quarantine group. The reporting is very unnoticeable at the moment. It's another solution for flaky tests. Tests get run but don't block the build.
The reason for quarantine is that the tests are so flaky that they fail almost on every run. There should be a issue about fixing it. The tests should get fixed, but there aren't many who care about addressing the problem.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.57%. Comparing base (bbc6224) to head (fbd4315).
Report is 609 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #23369      +/-   ##
============================================
+ Coverage     73.57%   74.57%   +0.99%     
- Complexity    32624    33955    +1331     
============================================
  Files          1877     1934      +57     
  Lines        139502   145132    +5630     
  Branches      15299    15870     +571     
============================================
+ Hits         102638   108229    +5591     
+ Misses        28908    28614     -294     
- Partials       7956     8289     +333     

Flag	Coverage Δ
inttests	27.71% <ø> (+3.12%)	⬆️
systests	24.56% <ø> (+0.24%)	⬆️
unittests	73.90% <ø> (+1.06%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 600 files with indirect coverage changes

[BewareMyPower]

the test is in the quarantine group. The reporting is very unnoticeable at the moment.

Where do these tests run? Could you point out a workflow for example?