-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] [broker] Fix incorrect stat sub.msgBacklogNoDelayed if enabled delayedDeliveryFixedDelayDetectionLookahead #23353
Open
poorbarcode
wants to merge
5
commits into
apache:master
Choose a base branch
from
poorbarcode:fix/delay_msg_backlog_if_delayedDeliveryFixedDelayDetectionLookahead
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DelayDetectionLookahead
poorbarcode
changed the title
[fix] [broker] Fix incorrect delayed msg metric if enabled delayedDeliveryFixedDelayDetectionLookahead
[draft] [fix] [broker] Fix incorrect delayed msg metric if enabled delayedDeliveryFixedDelayDetectionLookahead
Sep 26, 2024
poorbarcode
changed the title
[draft] [fix] [broker] Fix incorrect delayed msg metric if enabled delayedDeliveryFixedDelayDetectionLookahead
[draft] [fix] [broker] Fix incorrect stat sub.msgBacklogNoDelayed if enabled delayedDeliveryFixedDelayDetectionLookahead
Sep 26, 2024
poorbarcode
changed the title
[draft] [fix] [broker] Fix incorrect stat sub.msgBacklogNoDelayed if enabled delayedDeliveryFixedDelayDetectionLookahead
[fix] [broker] Fix incorrect stat sub.msgBacklogNoDelayed if enabled delayedDeliveryFixedDelayDetectionLookahead
Sep 26, 2024
Technoboy-
reviewed
Sep 26, 2024
@Override | ||
public boolean isAllWaitingReadMessagesAreFixedDelayed() { | ||
return shouldPauseDeliveryForDelayTracker(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pendingReadMessageAreFixedDelayed
?
lhotari
added
release/3.3.3
release/3.0.8
and removed
release/3.3.2
release/3.0.7
labels
Oct 10, 2024
lhotari
added
release/3.0.9
release/3.3.4
and removed
release/3.0.8
release/3.3.3
labels
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Background
sub.msgBacklogNoDelayed
is a large number, we will increase the consumer count to consume quickly.delayedDeliveryFixedDelayDetectionLookahead
and the messages encountered the feature,sub.msgDelayed
is always50k
andsub.msgBacklogNoDelayed
keeps increasing, but the consumers will receive nothing.Modifications
sub.msgBacklogNoDelayed
if enableddelayedDeliveryFixedDelayDetectionLookahead
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: x