Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] [broker] Fix incorrect stat sub.msgBacklogNoDelayed if enabled delayedDeliveryFixedDelayDetectionLookahead #23353

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

poorbarcode
Copy link
Contributor

@poorbarcode poorbarcode commented Sep 26, 2024

Motivation

Background

  • When we notice the sub.msgBacklogNoDelayed is a large number, we will increase the consumer count to consume quickly.
  • After enabling delayedDeliveryFixedDelayDetectionLookahead and the messages encountered the feature, sub.msgDelayed is always 50k and sub.msgBacklogNoDelayed keeps increasing, but the consumers will receive nothing.

Modifications

  • Correct the value of sub.msgBacklogNoDelayed if enabled delayedDeliveryFixedDelayDetectionLookahead
  • Write a test.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: x

@poorbarcode poorbarcode added this to the 4.0.0 milestone Sep 26, 2024
@poorbarcode poorbarcode self-assigned this Sep 26, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 26, 2024
@poorbarcode poorbarcode changed the title [fix] [broker] Fix incorrect delayed msg metric if enabled delayedDeliveryFixedDelayDetectionLookahead [draft] [fix] [broker] Fix incorrect delayed msg metric if enabled delayedDeliveryFixedDelayDetectionLookahead Sep 26, 2024
@poorbarcode poorbarcode changed the title [draft] [fix] [broker] Fix incorrect delayed msg metric if enabled delayedDeliveryFixedDelayDetectionLookahead [draft] [fix] [broker] Fix incorrect stat sub.msgBacklogNoDelayed if enabled delayedDeliveryFixedDelayDetectionLookahead Sep 26, 2024
@poorbarcode poorbarcode changed the title [draft] [fix] [broker] Fix incorrect stat sub.msgBacklogNoDelayed if enabled delayedDeliveryFixedDelayDetectionLookahead [fix] [broker] Fix incorrect stat sub.msgBacklogNoDelayed if enabled delayedDeliveryFixedDelayDetectionLookahead Sep 26, 2024
@Override
public boolean isAllWaitingReadMessagesAreFixedDelayed() {
return shouldPauseDeliveryForDelayTracker();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pendingReadMessageAreFixedDelayed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs release/3.0.10 release/3.3.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants