-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve] [bk] Upgrade BookKeeper dependency to 4.16.4 #21983
Merged
lhotari
merged 3 commits into
apache:master
from
hangc0276:chenhang/upgrade_bk_to_4.16.4
Jan 29, 2024
Merged
[improve] [bk] Upgrade BookKeeper dependency to 4.16.4 #21983
lhotari
merged 3 commits into
apache:master
from
hangc0276:chenhang/upgrade_bk_to_4.16.4
Jan 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
requested review from
lhotari,
Technoboy-,
horizonzy,
zymap and
poorbarcode
January 29, 2024 01:40
hangc0276
added
release/3.0.3
release/3.1.3
release/3.2.1
and removed
doc-not-needed
Your PR changes do not impact docs
labels
Jan 29, 2024
hangc0276
added
dependencies
Pull requests that update a dependency file
ready-to-test
labels
Jan 29, 2024
poorbarcode
approved these changes
Jan 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21983 +/- ##
============================================
- Coverage 73.65% 73.56% -0.09%
+ Complexity 32471 32452 -19
============================================
Files 1863 1863
Lines 138772 138772
Branches 15203 15203
============================================
- Hits 102213 102094 -119
- Misses 28665 28788 +123
+ Partials 7894 7890 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
horizonzy
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Technoboy-
approved these changes
Jan 29, 2024
lhotari
approved these changes
Jan 29, 2024
lhotari
pushed a commit
that referenced
this pull request
Jan 29, 2024
(cherry picked from commit ae272a5)
lhotari
pushed a commit
that referenced
this pull request
Jan 29, 2024
(cherry picked from commit ae272a5)
lhotari
pushed a commit
that referenced
this pull request
Jan 29, 2024
(cherry picked from commit ae272a5)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.1
cherry-picked/branch-3.2
dependencies
Pull requests that update a dependency file
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.3
release/3.1.3
release/3.2.1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
Motivation
BookKeeper 4.16.4 has been released and upgrade the BookKeeper dependency to 4.16.4
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: