[improve][broker] PIP-315: Configurable max delay limit for delayed delivery

[KevinLiLu]

PIP-315: Configurable max delay limit for delayed delivery (https://github.com/apache/pulsar/blob/master/pip/pip-315.md)

Motivation

Modifications

Verifying this change

• Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

• Added integration tests for end-to-end deployment with large payloads (10MB)
• Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository:

[github-actions]

@KevinLiLu Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

[lhotari]

LGTM. Great work. Thanks for the contribution!

I added an "optional" comment about using java.time.Duration for the public API.

[KevinLiLu]

Hi @lhotari, apologies for the churn but could you re-trigger the workflow? I missed the maxDelay parameter in a couple Cmd classes.

[dao-jun]

@KevinLiLu Please resolve the conflicts

[KevinLiLu]

@KevinLiLu Please resolve the conflicts

@dao-jun Thanks for pointing this out. I have resolved the conflict.

[codecov-commenter]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b14fcb4) 73.60% compared to head (963088d) 73.65%.
Report is 6 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #21798      +/-   ##
============================================
+ Coverage     73.60%   73.65%   +0.05%     
- Complexity    32411    32456      +45     
============================================
  Files          1861     1861              
  Lines        138674   138724      +50     
  Branches      15182    15188       +6     
============================================
+ Hits         102070   102180     +110     
+ Misses        28702    28660      -42     
+ Partials       7902     7884      -18     

Flag	Coverage Δ
inttests	24.10% <27.45%> (-0.10%)	⬇️
systests	23.70% <23.52%> (-0.02%)	⬇️
unittests	72.92% <98.03%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...org/apache/pulsar/broker/ServiceConfiguration.java	99.39% <100.00%> (+<0.01%)	⬆️
...pulsar/broker/admin/impl/PersistentTopicsBase.java	65.17% <100.00%> (-0.01%)	⬇️
...rg/apache/pulsar/broker/service/AbstractTopic.java	87.98% <100.00%> (+0.10%)	⬆️
.../common/policies/data/DelayedDeliveryPolicies.java	100.00% <ø> (ø)
...olicies/data/impl/DelayedDeliveryPoliciesImpl.java	93.33% <100.00%> (+1.66%)	⬆️
...ava/org/apache/pulsar/admin/cli/CmdNamespaces.java	78.64% <100.00%> (+0.06%)	⬆️
.../org/apache/pulsar/admin/cli/CmdTopicPolicies.java	89.61% <100.00%> (+0.04%)	⬆️
...in/java/org/apache/pulsar/admin/cli/CmdTopics.java	81.17% <100.00%> (+0.04%)	⬆️
...r/common/policies/data/HierarchyTopicPolicies.java	100.00% <100.00%> (ø)
...che/pulsar/common/policies/data/TopicPolicies.java	59.37% <100.00%> (+0.64%)	⬆️
... and 1 more

... and 72 files with indirect coverage changes

[dao-jun]

lgtm

[Jason918]

LGTM

[dao-jun]

@lhotari does all the conversations resolved?

[lhotari]

LGTM