[improve][proxy] Remove unnecessary executor callback; use assert #19670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljmarshall
added
type/enhancement
michaeljmarshall
requested review from
merlimat,
lhotari,
eolivelli and
codelipenghui
nicoloboschi
approved these changes
Mar 1, 2023
eolivelli
reviewed
Mar 1, 2023
| @@ -401,18 +400,21 @@ private void handleBrokerConnected(DirectProxyHandler directProxyHandler, Comman | |||
| } | |||
|
|
|||
| private void connectToBroker(InetSocketAddress brokerAddress) { | |||
| checkState(ctx.executor().inEventLoop(), "This method should be called in the event loop"); | |||
| assert ctx.executor().inEventLoop(); | |||
There was a problem hiding this comment.
"assert" is not enabled in production
I am not sure that we enable Java assertion in tests
coderzc
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
DirectProxyHandlerand theProxyConnectionare run in the same event loop to prevent context switching. As such, we do not need to schedule an event onto an event loop that is in fact the same event loop. Further, scheduling on that event loop could have resulted in uncaught failures because the method was run without any error handling.Additionally, we can use
assertto verify that we are in the event loop. Netty makes extensive use of this paradigm, as described in this PR #19653. The primary benefit here is that we skip some unnecessary volatile reads when running the code in production.Modifications
checkStatewithassertinProxyConnectionclassDirectProxyHandler.Verifying this change
This change is covered by the assertions that are added.
Does this pull request potentially affect one of the following parts:
This is a minor improvement that should not break anything.
Documentation
doc-not-neededMatching PR in forked repository
PR in forked repository: michaeljmarshall#33