From f604dedaf503342e32ce40b7a8965847644e15a2 Mon Sep 17 00:00:00 2001 From: Jiawen Wang <2876645134@qq.com> Date: Thu, 17 Oct 2024 12:39:19 +0800 Subject: [PATCH] update --- pip/pip-386.md | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/pip/pip-386.md b/pip/pip-386.md index c886096e29f07..1a7dad32db540 100644 --- a/pip/pip-386.md +++ b/pip/pip-386.md @@ -25,19 +25,6 @@ Add resetIncludeHead in CommandSubscribe to implement startMessageIdInclusive, a - PersistTopic#getNonDurableSubscription add the judge condition `(msgId.getBatchIndex() >= 0 || resetIncludeHead)`, entryId - 1 will execute **when msg is batch or the resetIncludeHead is true.** -```java - if (ledgerId >= 0 && entryId >= 0 - && msgId instanceof BatchMessageIdImpl - && (msgId.getBatchIndex() >= 0 || resetIncludeHead)) { - // When the start message is relative to a batch, we need to take one step back on the previous - // message, - // because the "batch" might not have been consumed in its entirety. - // The client will then be able to discard the first messages if needed. - entryId = msgId.getEntryId() - 1; - } -``` - - ### Binary protocol Add `reset_include_head` field to the `CommandSubscribe`. @@ -114,5 +101,5 @@ message CommandSubscribe { # Links -* Mailing List discussion thread: -* Mailing List voting thread: +* Mailing List discussion thread: https://lists.apache.org/thread/tvk9nl47gqtbx2nrdzknm4v8sm67ywp9 +* Mailing List voting thread: https://lists.apache.org/thread/x5xknyyr0pyrhwoslbxbbcj0o1xyyyp6