Skip to content

feat: support pattern subscription non persistent topic. #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 13, 2023

Conversation

shibd
Copy link
Member

@shibd shibd commented Jun 24, 2023

Motivation

Support pattern subscription non-persistent topic.

Modifications

  • Expose RegexSubscriptionMode to support pattern subscribe all/persistent only/non-persistent-only topic.

Verifying this change

  • Add Regex subscription unit test to cover when RegexSubscriptionMode = AllTopic case. More case cover by cpp clients.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • [] doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@shibd shibd added this to the 3.3.0 milestone Jun 24, 2023
@shibd shibd self-assigned this Jun 24, 2023
@shibd shibd marked this pull request as draft July 7, 2023 10:43
@shibd shibd marked this pull request as ready for review July 7, 2023 11:01
@BewareMyPower
Copy link
Contributor

Could you resolve the conflicts?

@shibd shibd force-pushed the reg_non_partition branch from cfd78d8 to daa44d4 Compare August 9, 2023 07:09
@shibd
Copy link
Member Author

shibd commented Aug 9, 2023

Could you resolve the conflicts?

Done, please review this PR first.

@shibd shibd force-pushed the reg_non_partition branch from daa44d4 to 6d050cf Compare August 13, 2023 05:01
@BewareMyPower BewareMyPower merged commit 19df7c3 into apache:main Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants