Skip to content

Fix acknowledgeCumulative never returns when accepting an invalid message id for a multi-topics consumer #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BewareMyPower
Copy link
Contributor

Motivation

The callback in acknowledgeCumulative will never be called for a multi-topics consumer when the message id is invalid.

Modifications

  • Fail the callback with ResultOperationNotSupported when the topic name of the message id is invalid
  • Keep the behavior the same for acknowledge
  • Add MultiTopicsConsumerTest.testAcknowledgeInvalidMessageId to verify an invalid message id won't block any acknowledge method

@BewareMyPower BewareMyPower added this to the 3.8.0 milestone Jun 6, 2025
@BewareMyPower BewareMyPower self-assigned this Jun 6, 2025
@BewareMyPower BewareMyPower added the bug Something isn't working label Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant