Fix acknowledgeCumulative never returns when accepting an invalid message id for a multi-topics consumer #492
+56
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The callback in
acknowledgeCumulative
will never be called for a multi-topics consumer when the message id is invalid.Modifications
ResultOperationNotSupported
when the topic name of the message id is invalidacknowledge
MultiTopicsConsumerTest.testAcknowledgeInvalidMessageId
to verify an invalid message id won't block any acknowledge method