Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken main branch after Pulsar image was upgraded to 3.2.0 #400

Merged

Conversation

BewareMyPower
Copy link
Contributor

@BewareMyPower BewareMyPower commented Feb 6, 2024

The apachepulsar/pulsar:latest image was upgraded to 3.2.0 recently, which results the following failed tests:

  • ExtensibleLoadManagerTest: there are no more lookup requests after namespace unload
  • ClientTest.testWrongListener: the lookup error message from broker does not contain the exception type

@BewareMyPower BewareMyPower added this to the 3.5.0 milestone Feb 6, 2024
@BewareMyPower BewareMyPower self-assigned this Feb 6, 2024
@BewareMyPower BewareMyPower marked this pull request as draft February 6, 2024 12:56
@BewareMyPower BewareMyPower force-pushed the bewaremypower/fix-load-manager-test branch from 5343251 to b5d0f2b Compare February 6, 2024 12:59
@BewareMyPower BewareMyPower marked this pull request as ready for review February 6, 2024 12:59
The `apachepulsar/pulsar:latest` image was upgraded to 3.2.0 recently,
which results the following failed tests:
- ExtensibleLoadManagerTest: there are no more lookup requests after
  namespace unload
- ClientTest.testWrongListener: the lookup error message from broker
  does not contain the exception type
@BewareMyPower BewareMyPower force-pushed the bewaremypower/fix-load-manager-test branch from b5d0f2b to 97d087e Compare February 6, 2024 13:23
@BewareMyPower BewareMyPower changed the title Fix extensible load manager test caused by Pulsar image upgrade Fix broken main branch after Pulsar image was upgraded to 3.2.0 Feb 6, 2024
@BewareMyPower BewareMyPower merged commit 289c930 into apache:main Feb 6, 2024
12 checks passed
@BewareMyPower BewareMyPower deleted the bewaremypower/fix-load-manager-test branch February 6, 2024 14:13
Copy link
Contributor

@heesung-sn heesung-sn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants