add change

Author: gh-yzou

integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationTest.java

@@ -1466,11 +1466,12 @@ public void testCreateGenericTableWithReservedProperty() {
                 Map.of("cat", currentCatalogName, "ns", ns))
             .post(
                 Entity.json(
-                    new CreateGenericTableRequest(
-                        tableIdentifier.name(),
-                        "format",
-                        "doc",
-                        Map.of("polaris.reserved", "true"))))) {
+                    CreateGenericTableRequest.builder()
+                        .setName(tableIdentifier.name())
+                        .setFormat("format")
+                        .setDoc("doc")
+                        .setProperties(Map.of("polaris.reserved", "true"))
+                        .build()))) {
       Assertions.assertThat(res.getStatus()).isEqualTo(Response.Status.BAD_REQUEST.getStatusCode());
       Assertions.assertThat(res.readEntity(String.class)).contains("reserved prefix");
     }

plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/rest/CreateGenericTableRESTRequest.java

@@ -36,13 +36,19 @@ public class CreateGenericTableRESTRequest extends CreateGenericTableRequest
   public CreateGenericTableRESTRequest(
       @JsonProperty(value = "name", required = true) String name,
       @JsonProperty(value = "format", required = true) String format,
+      @JsonProperty(value = "location") String location,
       @JsonProperty(value = "doc") String doc,
       @JsonProperty(value = "properties") Map<String, String> properties) {
-    super(name, format, doc, properties);
+    super(name, format, location, doc, properties);
   }
 
   public CreateGenericTableRESTRequest(CreateGenericTableRequest request) {
-    this(request.getName(), request.getFormat(), request.getDoc(), request.getProperties());
+    this(
+        request.getName(),
+        request.getFormat(),
+        request.getLocation(),
+        request.getDoc(),
+        request.getProperties());
   }
 
   @Override

spec/polaris-catalog-apis/generic-tables-api.yaml

@@ -193,14 +193,14 @@ components:
           type: string
         format:
           type: string
+        location:
+          type: string
         doc:
           type: string
         properties:
           type: object
           additionalProperties:
             type: string
-        location:
-          type: string
 
     GenericTable:
       type: object
@@ -215,7 +215,7 @@ components:
         
         - `doc` comment or description for the generic table
         
-        - `location` location for the table
+        - `location` table root location in URI format. For example: s3://<my-bucket>/path/to/table
       required:
         - name
         - format
@@ -224,14 +224,14 @@ components:
           type: string
         format:
           type: string
+        location:
+          type: string
         doc:
           type: string
         properties:
           type: object
           additionalProperties:
             type: string
-        location:
-          type: string
 
     LoadGenericTableResponse:
       description: Result used when a table is successfully loaded.