Address Alex feedback

Author: singhpk234

quarkus/commons/src/main/java/org/apache/polaris/commons/RelationalJdbcConfiguration.java

@@ -24,7 +24,7 @@
 import java.util.Map;
 import java.util.Optional;
 
-@ConfigMapping(prefix = "polaris.relation.jdbc.datasource")
+@ConfigMapping(prefix = "polaris.relational.jdbc.datasource")
 public interface RelationalJdbcConfiguration {
   /** realmId to configured Datasource name mapping. */
   @WithParentName

quarkus/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusProducers.java

@@ -258,13 +258,6 @@ public ActiveRolesProvider activeRolesProvider(
     return activeRolesProviders.select(Identifier.Literal.of(persistenceType)).get();
   }
 
-  //  @Produces
-  //  public DatasourceSupplier datasourceSupplier(
-  //      @Any RelationalJdbcConfiguration relationalJdbcConfiguration,
-  //      @All List<InstanceHandle<DataSource>> datasources) {
-  //    return new QuarkusDatasourceSupplier(relationalJdbcConfiguration, datasources);
-  //  }
-
   public void closeTaskExecutor(@Disposes @Identifier("task-executor") ManagedExecutor executor) {
     executor.close();
   }

quarkus/test-commons/build.gradle.kts

@@ -18,25 +18,25 @@
  */
 
 plugins {
-    alias(libs.plugins.jandex)
-    id("java-test-fixtures")
+  alias(libs.plugins.jandex)
+  id("java-test-fixtures")
 }
 
 configurations.all {
-    exclude(group = "org.antlr", module = "antlr4-runtime")
-    exclude(group = "org.scala-lang", module = "scala-library")
-    exclude(group = "org.scala-lang", module = "scala-reflect")
+  exclude(group = "org.antlr", module = "antlr4-runtime")
+  exclude(group = "org.scala-lang", module = "scala-library")
+  exclude(group = "org.scala-lang", module = "scala-reflect")
 }
 
 java {
-    sourceCompatibility = JavaVersion.VERSION_21
-    targetCompatibility = JavaVersion.VERSION_21
+  sourceCompatibility = JavaVersion.VERSION_21
+  targetCompatibility = JavaVersion.VERSION_21
 }
 
 dependencies {
-    implementation(enforcedPlatform(libs.quarkus.bom))
-    implementation("io.quarkus:quarkus-junit5")
-    implementation(platform(libs.testcontainers.bom))
-    implementation("org.testcontainers:testcontainers")
-    implementation("org.testcontainers:postgresql")
-}
+  implementation(enforcedPlatform(libs.quarkus.bom))
+  implementation("io.quarkus:quarkus-junit5")
+  implementation(platform(libs.testcontainers.bom))
+  implementation("org.testcontainers:testcontainers")
+  implementation("org.testcontainers:postgresql")
+}

quarkus/test-commons/src/main/java/org/apache/polaris/test/commons/PostgresRelationalJdbcLifeCycleManagement.java

@@ -97,7 +97,7 @@ private Map<String, String> generateDataSourceMappingProps(List<String> realms)
     Map<String, String> props = new HashMap<>();
     // polaris.relation.jdbc.datasource.realm=realm_ds
     for (String database : realms) {
-      props.put(String.format("polaris.relation.jdbc.datasource.%s", database), database + "_ds");
+      props.put(String.format("polaris.relational.jdbc.datasource.%s", database), database + "_ds");
     }
     return props;
   }