[Feature Request]: Go - support s7 reading

[DubbaThony]

What would you like to happen?

Currently in code path to read from s7, there is a stub in internal/s7/Reader.go a function parsePlcValue is a stub, causing all read requests for s7 fail with (cought) panic.

Without this function Im not aware of any way to use plc4go to read with s7.

I would like the function to get implementation, at least for some types.

Programming Languages

• plc4j
• plc4go
• plc4c
• plc4net

Protocols

• AB-Ethernet
• ADS /AMS
• BACnet/IP
• CANopen
• DeltaV
• DF1
• EtherNet/IP
• Firmata
• KNXnet/IP
• Modbus
• OPC-UA
• S7

[chrisdutz]

Should be easy as we initially had that working, but due to a refactoring of the underlying mspec, which broke the go module, we simply disabled things there. If you would like to work on that a PR would be highly welcome.

[DubbaThony]

Honestly I think I would break more than I would help. Especially that from what I understand the method should be closely following Java version, and I don't really understand Java code. I suppose I could attempt to "freestyle" it out, though Im uncertain if that wouldn't be more burden on maintainers to check my work / point out issues compared to having someone who speaks Java to port it 1:1 and have codebase consistent.

I don't have PLC programming setup, the PLC I work on is pre-programmed and Im just writing integration with it, so I could test only few types (string, wstring, dint, int) that are already in use in the specific PLC I temporarly have.

[chrisdutz]

So if you want me to take care of this, I have switched to doing stuff, if I receive monetary gratification in return (Sopped doing everything for free) ... If you're interested, feel free to contact me. Otherwise you would need to find someone who does this for you or ... well ... learn something and do it yourself.

I'm sorry that I have to be so blunt, but in the last 9 years I had put so much time, effort and private money into PLC4X with the hope I would receive gratification from the companies I am helping, but that didn't work out. So I have to turn the model around: Pay first, get work done then.

[DubbaThony]

I understand and don't worry about the bluntness. And fair enough, that monetary issue absolutely does exist and is valid 🫤.

For me that would be paying from my personal money, not from company's pocket. For my project I've written marshalling that covers what I need and used lower-level library.

I guess issue will wait for someone else.