Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of star-tree index with null handling enabled when no null values in segment columns #14177

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

yashmayya
Copy link
Collaborator

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 3.70370% with 26 lines in your changes missing coverage. Please review.

Project coverage is 63.83%. Comparing base (59551e4) to head (273ca9c).
Report is 1170 commits behind head on master.

Files with missing lines Patch % Lines
.../org/apache/pinot/core/startree/StarTreeUtils.java 3.70% 25 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14177      +/-   ##
============================================
+ Coverage     61.75%   63.83%   +2.07%     
- Complexity      207     1534    +1327     
============================================
  Files          2436     2622     +186     
  Lines        133233   144401   +11168     
  Branches      20636    22103    +1467     
============================================
+ Hits          82274    92174    +9900     
- Misses        44911    45432     +521     
- Partials       6048     6795     +747     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 55.47% <3.70%> (-6.24%) ⬇️
java-21 63.70% <3.70%> (+2.08%) ⬆️
skip-bytebuffers-false 63.81% <3.70%> (+2.06%) ⬆️
skip-bytebuffers-true 63.68% <3.70%> (+35.95%) ⬆️
temurin 63.83% <3.70%> (+2.07%) ⬆️
unittests 63.82% <3.70%> (+2.08%) ⬆️
unittests1 55.50% <3.70%> (+8.60%) ⬆️
unittests2 34.36% <0.00%> (+6.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yashmayya yashmayya marked this pull request as ready for review October 8, 2024 12:17
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Jackie-Jiang Jackie-Jiang merged commit d016df3 into apache:master Oct 9, 2024
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants