Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable Netty native transports in ClusterTest #12527

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Mar 1, 2024

Motivation

by default NettyConfig does not use native transports.

Modifications

  • update Netty properties in ClusterTest.java

Result

This change enables Netty native transports for all integration tests.

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.48%. Comparing base (59551e4) to head (031634c).
Report is 133 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12527      +/-   ##
============================================
- Coverage     61.75%   61.48%   -0.28%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2452      +16     
  Lines        133233   133848     +615     
  Branches      20636    20766     +130     
============================================
+ Hits          82274    82291      +17     
- Misses        44911    45394     +483     
- Partials       6048     6163     +115     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (-0.01%) ⬇️
integration <0.01% <ø> (-0.01%) ⬇️
integration1 <0.01% <ø> (-0.01%) ⬇️
integration2 0.00% <ø> (ø)
java-11 61.40% <ø> (-0.31%) ⬇️
java-21 61.35% <ø> (-0.27%) ⬇️
skip-bytebuffers-false 61.44% <ø> (-0.30%) ⬇️
skip-bytebuffers-true 61.32% <ø> (+33.59%) ⬆️
temurin 61.48% <ø> (-0.28%) ⬇️
unittests 61.47% <ø> (-0.28%) ⬇️
unittests1 46.38% <ø> (-0.51%) ⬇️
unittests2 27.75% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sullis sullis marked this pull request as draft March 1, 2024 06:58
@sullis sullis force-pushed the sean/netty-native-transport-cluster-test branch 2 times, most recently from c2c41e1 to a409f0c Compare March 2, 2024 01:23
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider testing both native and non-native? Basically randomly choose whether to set the flag

@sullis
Copy link
Contributor Author

sullis commented Mar 6, 2024

for discussion: enable native transports by default in NettyConfig.java

#12577

@sullis sullis force-pushed the sean/netty-native-transport-cluster-test branch from a409f0c to 031634c Compare March 16, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants