Rewrite PinotQuery based on expression hints at instance/segment level (#8451)

* Rewrite PinotQuery based on expression hints at segment level

* Address comments

Author: xiangfu0

pinot-common/src/main/java/org/apache/pinot/common/request/context/predicate/BasePredicate.java

@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.common.request.context.predicate;
+
+import org.apache.pinot.common.request.context.ExpressionContext;
+
+
+/**
+ * Abstract predicate with left-hand side expression
+ */
+public abstract class BasePredicate implements Predicate {
+
+  protected ExpressionContext _lhs;
+
+  public BasePredicate(ExpressionContext lhs) {
+    _lhs = lhs;
+  }
+
+  @Override
+  public ExpressionContext getLhs() {
+    return _lhs;
+  }
+
+  @Override
+  public void setLhs(ExpressionContext lhs) {
+    _lhs = lhs;
+  }
+}

pinot-common/src/main/java/org/apache/pinot/common/request/context/predicate/EqPredicate.java

@@ -25,12 +25,11 @@
 /**
  * Predicate for EQ.
  */
-public class EqPredicate implements Predicate {
-  private final ExpressionContext _lhs;
+public class EqPredicate extends BasePredicate {
   private final String _value;
 
   public EqPredicate(ExpressionContext lhs, String value) {
-    _lhs = lhs;
+    super(lhs);
     _value = value;
   }
 
@@ -39,10 +38,6 @@ public Type getType() {
     return Type.EQ;
   }
 
-  @Override
-  public ExpressionContext getLhs() {
-    return _lhs;
-  }
 
   public String getValue() {
     return _value;

pinot-common/src/main/java/org/apache/pinot/common/request/context/predicate/InPredicate.java

@@ -26,12 +26,11 @@
 /**
  * Predicate for IN.
  */
-public class InPredicate implements Predicate {
-  private final ExpressionContext _lhs;
+public class InPredicate extends BasePredicate {
   private final List<String> _values;
 
   public InPredicate(ExpressionContext lhs, List<String> values) {
-    _lhs = lhs;
+    super(lhs);
     _values = values;
   }
 
@@ -40,11 +39,6 @@ public Type getType() {
     return Type.IN;
   }
 
-  @Override
-  public ExpressionContext getLhs() {
-    return _lhs;
-  }
-
   public List<String> getValues() {
     return _values;
   }

pinot-common/src/main/java/org/apache/pinot/common/request/context/predicate/IsNotNullPredicate.java

@@ -25,23 +25,17 @@
 /**
  * Predicate for IS_NOT_NULL.
  */
-public class IsNotNullPredicate implements Predicate {
-  private final ExpressionContext _lhs;
+public class IsNotNullPredicate extends BasePredicate {
 
   public IsNotNullPredicate(ExpressionContext lhs) {
-    _lhs = lhs;
+    super(lhs);
   }
 
   @Override
   public Type getType() {
     return Type.IS_NOT_NULL;
   }
 
-  @Override
-  public ExpressionContext getLhs() {
-    return _lhs;
-  }
-
   @Override
   public boolean equals(Object o) {
     if (this == o) {

pinot-common/src/main/java/org/apache/pinot/common/request/context/predicate/IsNullPredicate.java

@@ -25,23 +25,17 @@
 /**
  * Predicate for IS_NULL.
  */
-public class IsNullPredicate implements Predicate {
-  private final ExpressionContext _lhs;
+public class IsNullPredicate extends BasePredicate {
 
   public IsNullPredicate(ExpressionContext lhs) {
-    _lhs = lhs;
+    super(lhs);
   }
 
   @Override
   public Type getType() {
     return Type.IS_NULL;
   }
 
-  @Override
-  public ExpressionContext getLhs() {
-    return _lhs;
-  }
-
   @Override
   public boolean equals(Object o) {
     if (this == o) {

pinot-common/src/main/java/org/apache/pinot/common/request/context/predicate/JsonMatchPredicate.java

@@ -25,12 +25,11 @@
 /**
  * Predicate for JSON_MATCH.
  */
-public class JsonMatchPredicate implements Predicate {
-  private final ExpressionContext _lhs;
+public class JsonMatchPredicate extends BasePredicate {
   private final String _value;
 
   public JsonMatchPredicate(ExpressionContext lhs, String value) {
-    _lhs = lhs;
+    super(lhs);
     _value = value;
   }
 
@@ -39,11 +38,6 @@ public Type getType() {
     return Type.JSON_MATCH;
   }
 
-  @Override
-  public ExpressionContext getLhs() {
-    return _lhs;
-  }
-
   public String getValue() {
     return _value;
   }

pinot-common/src/main/java/org/apache/pinot/common/request/context/predicate/NotEqPredicate.java

@@ -25,12 +25,11 @@
 /**
  * Predicate for NOT_EQ.
  */
-public class NotEqPredicate implements Predicate {
-  private final ExpressionContext _lhs;
+public class NotEqPredicate extends BasePredicate {
   private final String _value;
 
   public NotEqPredicate(ExpressionContext lhs, String value) {
-    _lhs = lhs;
+    super(lhs);
     _value = value;
   }
 
@@ -39,11 +38,6 @@ public Type getType() {
     return Type.NOT_EQ;
   }
 
-  @Override
-  public ExpressionContext getLhs() {
-    return _lhs;
-  }
-
   public String getValue() {
     return _value;
   }

pinot-common/src/main/java/org/apache/pinot/common/request/context/predicate/NotInPredicate.java

@@ -26,12 +26,11 @@
 /**
  * Predicate for NOT_IN.
  */
-public class NotInPredicate implements Predicate {
-  private final ExpressionContext _lhs;
+public class NotInPredicate extends BasePredicate {
   private final List<String> _values;
 
   public NotInPredicate(ExpressionContext lhs, List<String> values) {
-    _lhs = lhs;
+    super(lhs);
     _values = values;
   }
 
@@ -40,11 +39,6 @@ public Type getType() {
     return Type.NOT_IN;
   }
 
-  @Override
-  public ExpressionContext getLhs() {
-    return _lhs;
-  }
-
   public List<String> getValues() {
     return _values;
   }

pinot-common/src/main/java/org/apache/pinot/common/request/context/predicate/Predicate.java

@@ -54,4 +54,9 @@ public boolean isExclusive() {
    * Returns the left-hand side expression of the predicate.
    */
   ExpressionContext getLhs();
+
+  /**
+   * Sets the left-hand side expression of the predicate.
+   */
+  void setLhs(ExpressionContext lhs);
 }

pinot-common/src/main/java/org/apache/pinot/common/request/context/predicate/RangePredicate.java

@@ -28,7 +28,7 @@
  * Predicate for RANGE.
  * <p>Pinot uses RANGE to represent '>', '>=', '<', '<=', BETWEEN so that intersection of multiple ranges can be merged.
  */
-public class RangePredicate implements Predicate {
+public class RangePredicate extends BasePredicate {
   public static final char DELIMITER = Range.DELIMITER;
   public static final char LOWER_EXCLUSIVE = Range.LOWER_EXCLUSIVE;
   public static final char LOWER_INCLUSIVE = Range.LOWER_INCLUSIVE;
@@ -39,7 +39,6 @@ public class RangePredicate implements Predicate {
   // For backward-compatibility
   private static final String LEGACY_DELIMITER = "\t\t";
 
-  private final ExpressionContext _lhs;
   private final boolean _lowerInclusive;
   private final String _lowerBound;
   private final boolean _upperInclusive;
@@ -56,7 +55,7 @@ public class RangePredicate implements Predicate {
    * </ul>
    */
   public RangePredicate(ExpressionContext lhs, String range) {
-    _lhs = lhs;
+    super(lhs);
     String[] split = StringUtils.split(range, DELIMITER);
     if (split.length != 2) {
       split = StringUtils.split(range, LEGACY_DELIMITER);
@@ -72,7 +71,7 @@ public RangePredicate(ExpressionContext lhs, String range) {
 
   public RangePredicate(ExpressionContext lhs, boolean lowerInclusive, String lowerBound, boolean upperInclusive,
       String upperBound) {
-    _lhs = lhs;
+    super(lhs);
     _lowerInclusive = lowerInclusive;
     _lowerBound = lowerBound;
     _upperInclusive = upperInclusive;
@@ -84,11 +83,6 @@ public Type getType() {
     return Type.RANGE;
   }
 
-  @Override
-  public ExpressionContext getLhs() {
-    return _lhs;
-  }
-
   public boolean isLowerInclusive() {
     return _lowerInclusive;
   }