-
Notifications
You must be signed in to change notification settings - Fork 48
test with pekko 1.2.0 #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@He-Pin is the idea that pekko-http 1.3.0 uses pekko core 1.2 as its minimum supported version? I'm neutral. I don't especially mind leaving the depenency on 1.1 with the knowledge that 1.2 works too. |
@pjfanning I think so, because Play will use Pekko 1.2.0 and Pekko http next anyway, we should make Pekko http use 1.2.0 and remove all usage of the deprecated methods. And we deleted nothing in Pekko 1.2.0, so that's shold be fine. |
@raboof what do you think of us making pekko-http 1.3.0 (next minor release) have a defined dependency on pekko (core) 1.2.0? It's not necessary since the code still works with Pekko 1.1.x but it might be useful to suggest that users upgrade. |
@mkurz wdyt? |
Play will definitely bump Pekko to 1.2.x and Pekko Http to 1.3.x (assuming it will be released within the next couple of weeks) for it's next major release. In the end for Play it's not really relevant if Pekko Http itself depends on Pekko 1.1 or 1.2 since we just force Pekko 1.2 anyway. (assuming pekko-http next works with both 1.1 and 1.2 which is what you say in this thread). Not sure what what you want to do, depending on one or the another should be fine for users. I would guess someone who upgrades Pekko Http to 1.3 will also likely upgrade Pekko to 1.2 anyway. |
Because many methods have been deprecated in 1.2, if they are not migrated to the replacement methods, compilation in strict mode will cause errors, which is not good for users in any way. Why not compile with the latest version and fix all the problems in this new version, and maintain it well as the last version supporting Java 8? So I'm +1 on migrating to Pekko 1.2.0 |
Traditionally we haven't, because that is most flexible for users: if pekko-http depends on 1.1.x you can use it with either 1.1.x or 1.2.x, but if pekko-http depends on 1.2.x then you can no longer assume it will work with 1.1.x (since we provide backwards but not forwards compatibility). We documented this in https://pekko.apache.org/docs/pekko/current/project/downstream-upgrade-strategy.html
I think traditionally we 'suggested' that by updating the 'bom' artifact (though I don't think I ever used that myself...). I like the tendency to be more proactive in nudging users to upgrade. For that reason I'm in favor of updating the version here, even if it's not 'needed'. We should probably tweak the wording in https://pekko.apache.org/docs/pekko/current/project/downstream-upgrade-strategy.html to reflect that, then. |
Akka once did that for commercial support, but as an open-source project, I think now we should make it simpler for both users and maintainers. |
@raboof the pekko-bom exposes the same dependency versions as the jar pom files. Since we don't need anything from pekko 1.2, I don't think we should merge this PR. |
But the users are using Pekko 1.2.0, and now, Pekko grpc and Pekko http are using many deprecated methods. |
This is why I want to get pekko 2.0.0-M1 released so that we can branch pekko-http etc and start working on 2.0.0 updates for those modules too. I already have a few PRs for pekko-http. |
just experimenting with staging version of this release (an RC being voted on)