Skip to content

GH-3246: Clarify the behaviour of big decimal for BYTE_ARRAY #3270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

GH-3246: Clarify the behaviour of big decimal for BYTE_ARRAY #3270

wants to merge 2 commits into from

Conversation

ArnavBalyan
Copy link
Member

  • The behaviour of BYTE_ARRAY or FIXED_LEN_BYTE_ARRAY for big decimals is not clear from the docs.
  • Added code comments at the read/writer to make the behaviour more clear for the reader.
  • Fixes Is big Decimal in Parquet big endian? #3246

@ArnavBalyan
Copy link
Member Author

cc @shangxinli @wgtmac could you please review thanks!

wgtmac
wgtmac reviewed Aug 24, 2025
View reviewed changes
...uet-column/src/main/java/org/apache/parquet/column/values/plain/BinaryPlainValuesReader.java
import org.slf4j.LoggerFactory;

/**
* ValuesReader for variable-length {@code BYTE_ARRAY} columns.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the good place to add the comment since this class is for a specific encoding of binary physical type.

As I have replied in the issue, the spec is clear on this so we don't even need the explaination.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, yes on retrospect code comment may not be the best, I'll check if the readme can be made more clear since the user pointed to the readme asking for clarity. Will iterate and get back thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wgtmac wgtmac wgtmac left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is big Decimal in Parquet big endian?
2 participants
@ArnavBalyan @wgtmac