Skip to content
This repository was archived by the owner on May 10, 2024. It is now read-only.

Conversation

@xhochy
Copy link
Member

@xhochy xhochy commented May 8, 2016

No description provided.

@wesm
Copy link
Member

wesm commented May 9, 2016

+1, thanks

@asfgit asfgit closed this in 72881a5 May 9, 2016
@wesm
Copy link
Member

wesm commented May 9, 2016

We're also going to want to create a public API for file writing https://github.com/apache/parquet-cpp/tree/master/src/parquet/api

I'm sort of lukewarm on the api directory; I would be fine with a parquet/parquet.h (or parquet/api.h) with everything public in it. let me know what you think

@xhochy
Copy link
Member Author

xhochy commented May 9, 2016

I'm okish with the api directory but would be -1 on the single parquet/parquet.h header. We already have some name collisions between Arrow and Parquet and although we have them nicely split up into namespaces, I would prefer to import only the really needed declarations.

asfgit pushed a commit to apache/arrow that referenced this pull request May 10, 2016
Depends on (mainly one line fixes):

- [x] apache/parquet-cpp#99
- [x] apache/parquet-cpp#98
- [x] apache/parquet-cpp#97

Author: Uwe L. Korn <uwelk@xhochy.com>
Author: Wes McKinney <wesm@apache.org>

Closes #73 from xhochy/arrow-91 and squashes the following commits:

7579fed [Uwe L. Korn] Mark single argument constructor as explicit
47441a1 [Uwe L. Korn] Assert that no exception was thrown
5fa1026 [Uwe L. Korn] Incorporate review comments
8d2db22 [Uwe L. Korn] ARROW-91: Basic Parquet read support
d9940d8 [Wes McKinney] Public API draft
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants