-
Notifications
You must be signed in to change notification settings - Fork 23
Add Support for Swift 5.7 #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @Andrea-Scuderi for this contribution. Do you have an Apache CLA on file I was not able to locate one. We may continue to hold merging this PR until we've cut over to the new GHA flow and away from Travis. |
Yes, I've sent a CLA the 11/11/2019. |
Hi @Andrea-Scuderi -- we've finally managed to get GitHub Action based CI working for this repository. Apologies for the very long delay. Would you have the time and interest to rebase this PR to the current master so we can get it merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have the time to accept the two small changes to the CHANGELOG files and update the .github/workflows/ci.yml that would be great.
…rfile" This reverts commit e8461a3.
@dgrove-oss I've updated the branch with your suggestions. Could you run the CI? |
Thanks for the quick response! CI run approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- Thanks for your patience!
Add support for Swift 5.7
swift57Action
swiftbuild.py
swiftbuild.py.launcher.swift
_WhiskRuntime
structMerry Christmas and Happy New Year! 🎄