Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-12852 Refactor TestRecordPath to improve expressiveness and reduce duplication #9198

Closed
wants to merge 2 commits into from

Conversation

EndzeitBegins
Copy link
Contributor

Summary

NIFI-12852

Refactors the test suite for the Record Path DSL to:

  • reduce duplication for common test setup
  • improving structure by grouping correlating tests under a @Nested class
  • improve expressiveness of tests by stating desired behaviour in method names
  • adding additional test cases for existing untested behaviour

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@EndzeitBegins
Copy link
Contributor Author

EndzeitBegins commented Aug 30, 2024

Rebased onto latest commit of main to resolve merge-issue due to NIFI-13643 / #9163 affecting the same file.

@EndzeitBegins EndzeitBegins marked this pull request as draft August 31, 2024 17:35
@EndzeitBegins EndzeitBegins marked this pull request as ready for review August 31, 2024 18:13
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the thorough reorganization @EndzeitBegins, the latest version looks good! +1 merging

@EndzeitBegins EndzeitBegins deleted the NIFI-12852 branch September 3, 2024 04:31
@EndzeitBegins
Copy link
Contributor Author

Thank you for the review & merge, @exceptionfactory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants