sys/log, fs/fcb: Add trailer per entry in logs and fcb

- Add syscfgs for controlling the functionality
  along with callbacks
- This is an optional feature enabled only if
  LOG_FLAGS_TRAILER_SUPPORT: 1

Author: vrahane

fs/fcb2/include/fcb/fcb2.h

@@ -304,6 +304,15 @@ int fcb2_clear(struct fcb2 *fcb);
  */
 int fcb2_area_info(struct fcb2 *fcb, int sector, int *elemsp, int *bytesp);
 
+/**
+ * Length of data in flash considering alignment
+ *
+ * @param range Active range
+ * @param len Length to be calculated using alignment
+ *
+ */
+int fcb2_len_in_flash(const struct flash_sector_range *range, uint16_t len);
+
 #ifdef __cplusplus
 }
 

fs/fcb2/src/fcb.c

@@ -101,6 +101,15 @@ fcb2_init(struct fcb2 *fcb)
     return rc;
 }
 
+int
+fcb2_len_in_flash(const struct flash_sector_range *range, uint16_t len)
+{
+    if (range->fsr_align <= 1) {
+        return len;
+    }
+    return (len + (range->fsr_align - 1)) & ~(range->fsr_align - 1);
+}
+
 int
 fcb2_free_sector_cnt(struct fcb2 *fcb)
 {

fs/fcb2/src/fcb_priv.h

@@ -40,15 +40,6 @@ struct fcb2_sector_info {
     uint16_t si_sector_in_range;          /* Sector number relative to si_range */
 };
 
-static inline int
-fcb2_len_in_flash(const struct flash_sector_range *range, uint16_t len)
-{
-    if (range->fsr_align <= 1) {
-        return len;
-    }
-    return (len + (range->fsr_align - 1)) & ~(range->fsr_align - 1);
-}
-
 int fcb2_getnext_in_area(struct fcb2 *fcb, struct fcb2_entry *loc);
 
 static inline int

hw/mcu/native/src/hal_flash.c

@@ -152,7 +152,7 @@ static int
 flash_native_write_internal(uint32_t address, const void *src, uint32_t length,
                             int allow_overwrite)
 {
-    static uint8_t buf[256];
+    uint8_t buf[256] = {0};
     uint32_t cur;
     uint32_t end;
     int chunk_sz;

sys/log/common/include/log_common/log_common.h

@@ -28,6 +28,7 @@ extern "C" {
 #endif
 
 struct log;
+struct log_entry_hdr;
 
 #define LOG_VERSION_V3  3
 
@@ -132,11 +133,79 @@ typedef void log_append_cb(struct log *log, uint32_t idx);
 
 /** @typdef log_notify_rotate_cb
  * @brief Callback that is executed each time we are about to rotate a log.
- * 
- * @param log                   The log that is about to rotate 
+ *
+ * @param log                   The log that is about to rotate
  */
 typedef void log_notify_rotate_cb(const struct log *log);
 
+/** @typedef log_trailer_append_cb
+ * @brief Callback that is executed each time the corresponding log entry is
+ * appended to
+ *
+ * @param log                   The log that was just appended to
+ * @param buf                   Buffer to append trailer to
+ * @param buflen                Pointer to the length of the trailer to be filled up
+ *                              optionally
+ * @param loc                   Argument pointing to the location of
+ *                              the entry
+ * @param f_offset              Pointer to the offset(optional) at which append should
+ *                              happen
+ *
+ * @return                      0 on success, non-zero on failure
+ */
+typedef int log_trailer_append_cb(struct log *log, uint8_t *buf,
+                                  uint16_t *buflen, void *loc,
+                                  uint16_t *f_offset);
+
+/** @typedef log_mbuf_trailer_append_cb
+ * @brief Callback that is executed each time the corresponding log entry is
+ * appended to
+ *
+ * @param log                   The log that was just appended to
+ * @param om                    Pointer to the mbuf that contains the log entry
+ * @param loc                   Argument pointing to the location of
+ *                              the entry
+ * @param f_offset              The offset(optional) at which append should
+ *                              happen
+ *
+ * @return                      0 on success, non-zero on failure
+ */
+typedef int log_trailer_mbuf_append_cb(struct log *log, struct os_mbuf *om,
+                                       void *loc, uint16_t f_offset);
+
+/** @typedef log_process_trailer_cb
+ * @brief Callback that is executed each time a trailer is processed
+ *
+ * @param log                   The log that was just appended to
+ * @param arg                   Void pointer for a custom arg
+ * @param dptr                  Pointer to the data buffer
+ * @param len                   Length of the trailer
+ *
+ * @return                      0 on success, non-zero on failure
+ */
+typedef int log_process_trailer_cb(struct log *log, void *arg, const void *dptr,
+                                   uint16_t len);
+
+/** @typedef log_trailer_len_cb
+ * @brief Callback used to read length of trailer in a log entry
+ *
+ * @param log                   The log the trailer is to be read from
+ * @param hdr                   Log entry header of the log entry the log is
+ *                              read from
+ * @return                      Length of the appended trailer
+ */
+typedef uint16_t log_trailer_len_cb(struct log *log, const struct log_entry_hdr *hdr);
+
+/** @typedef log_trailer_data_len_cb
+ * @brief Callback used to read length of trailer data in a log entry
+ *
+ * @param log                   The log the trailer is to be read from
+ * @param hdr                   Log entry header of the log entry the log is
+ *                              read from
+ * @return                      Length of the appended trailer data
+ */
+typedef uint16_t log_trailer_data_len_cb(struct log *log, const struct log_entry_hdr *hdr);
+
 #ifdef __cplusplus
 }
 #endif