Test macos installation #6231
Test macos installation #6231
Conversation
|
I added logic to run installation tasks only if the diff between this branch and the mxnet's master branch contains install.md. Note the installation_source_test task fails in Travis because my changes to Also @mli the Jenkins server couldn't clone this repo for some reason...can you help retrigger the build? |
|
i don't know jenkins failed to clone this pr, maybe due to there is too many commits. but it seems to be fixed now |
|
Yes I think it's a known issue with git pull request builder. |
|
@mli can we push this through now? |
.travis.yml
Outdated
| @@ -16,8 +16,10 @@ env: | |||
| # run tests/cpp | |||
| - TASK=cpp_test | |||
| # run tests/python | |||
| - TASK=python_test | |||
There was a problem hiding this comment.
@mli asked me to remove Python and R tests. Please let me know if you want to keep it in or not.
There was a problem hiding this comment.
I think its better to keep python tests on mac until we have our own mac servers.
|
Why are we testing pip install here? Shouldn't it be tested in mxnet-distro? That's the place that's creating the pip packages. |
|
@piiswrong This tests the installation instructions to make sure that the guide works. The testing in mxnet-distro needs to happen too, but that is a separate in-progress item. |
|
pip install depends on the pip package which is not in this repo. Putting it here can cause test fails without changes in mxnet repo. These tests should be moved into mxnet-distro source install tests can be here. |
|
I advocate to push this in because
|
|
I've added the tests in mxnet-distro for the immediate release. Eric has a point that having external dependencies for tests is bad and unless we mock the dependencies there isn't a way around it. Also, adding a test for |
@szha I'm going to merge this PR, its goal is to test install.md. Once mxnet-distro moved to mxnet, we can run the test for mxnet-distro first.
This reverts commit bc83786.
This PR adds logic to test @sandeep-krishnamurthy's python installation guide for MacOS CPU on Travis.
We test the installation in a clean environment via pip, virtualenv, and from source.