Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[pip] script for making python wheel for mxnet, CPU-only version #4814

Merged
merged 2 commits into from
Jan 27, 2017
Merged

[pip] script for making python wheel for mxnet, CPU-only version #4814

merged 2 commits into from
Jan 27, 2017

Conversation

szha
Copy link
Member

@szha szha commented Jan 26, 2017

@piiswrong

This is continuation of #4754. It accomplishes static-linking of opencv and openblas (and their dependencies) to mxnet. The build is tested on ubuntu and amazon linux. Installation is tested on ubuntu. Cross-os/arch/platform build is probably not gonna work.

Continuing from #4754, code-wise potential next steps are:

  1. More testing on different platforms. More auto-detection of tools and safeguard.
  2. Also, the currently supported package managers that wheel-build can depend on are apt-get and yum. This can be extended if such need arises.
  3. looking into https://github.com/pypa/manylinux and see if it's possible to share builds across linux platforms.

In addition, we can:

  1. Once tested, upload to PyPI
  2. Set up auto-builds and auto-uploads (and get our badges for them)
  3. Anaconda, anyone?
  4. Update doc.

# For building pip wheel
ifeq ($(BUILD_PIP_WHEEL), 1)
USE_BLAS=openblas
ADD_CFLAGS += -L~/lib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a tmp dir under mxnet. Don't put things into home

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we should use make/pip_ubuntu.mk make/pip_osx.mk etc to do this

echo "Need a package manager to install build tools, e.g. apt/yum"
exit 1
fi
sudo pip install -U pip setuptools wheel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better fix the version here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@piiswrong piiswrong merged commit 7165476 into apache:master Jan 27, 2017
@szha szha deleted the pip_wheel branch January 27, 2017 04:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants