This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Introduce a developer mode option in Makefile #4364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this option will enable two addtionals for now: 1. Create symbol even for optimized build 2. Enforce warning as error while I am here, clean up all warnings so that I can get a clean build in developer mode.
|
I don't know what to config Travis CI to enable DEV=1 to enforce zero warning. |
piiswrong
reviewed
Dec 25, 2016
| @@ -31,6 +31,10 @@ include $(DMLC_CORE)/make/dmlc.mk | |||
| WARNFLAGS= -Wall | |||
| CFLAGS = -DMSHADOW_FORCE_STREAM $(WARNFLAGS) | |||
|
|
|||
| ifeq ($(DEV), 1) | |||
| CFLAGS += -g -Werror | |||
There was a problem hiding this comment.
you don't need -g just to generate symbol. I think there is an option to do it without turning off optimization
There was a problem hiding this comment.
i didn't get you. -g is not enable debug but just generate symbol.
-g Produce debugging information in the operating system's native format (stabs, COFF, XCOFF, or DWARF 2). GDB can
work with this debugging information.
piiswrong
pushed a commit
to piiswrong/mxnet
that referenced
this pull request
Dec 29, 2016
this option will enable two addtionals for now: 1. Create symbol even for optimized build 2. Enforce warning as error while I am here, clean up all warnings so that I can get a clean build in developer mode.
piiswrong
pushed a commit
to piiswrong/mxnet
that referenced
this pull request
Dec 29, 2016
this option will enable two addtionals for now: 1. Create symbol even for optimized build 2. Enforce warning as error while I am here, clean up all warnings so that I can get a clean build in developer mode.
piiswrong
pushed a commit
that referenced
this pull request
Dec 29, 2016
this option will enable two addtionals for now: 1. Create symbol even for optimized build 2. Enforce warning as error while I am here, clean up all warnings so that I can get a clean build in developer mode.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this option will enable two addtionals for now:
while I am here, clean up all warnings so that I can get a clean build in developer mode.