This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Expose get_all_registered_operators and get_operator_arguments in the… #15364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @larroy Overall looks good to me. However, this is adding 2 new public facing APIs. I prefer you create a RFC github issue, have a discussion and get community feedback on the same. |
marcoabreu
reviewed
Jun 26, 2019
marcoabreu
reviewed
Jun 26, 2019
@marcoabreu addressed your comments. |
marcoabreu
approved these changes
Jun 27, 2019
@mxnet-label-bot add [pr-awaiting-review] |
wkcn
approved these changes
Jul 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! LGTM. Thank you!
If there is not any propose in the RFC, it's good to merge. |
sandeep-krishnamurthy
approved these changes
Jul 4, 2019
Merged. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Python API.
Resolves #15367
@sandeep-krishnamurthy
Checklist
I checked that opperf.py runs with the changes provided.
Essentials
Please feel free to remove inapplicable items for your PR.