Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix save_params warning mesage #11532

Merged
merged 1 commit into from
Jul 2, 2018
Merged

Fix save_params warning mesage #11532

merged 1 commit into from
Jul 2, 2018

Conversation

piiswrong
Copy link
Contributor

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@piiswrong piiswrong requested a review from szha as a code owner July 2, 2018 20:50
@piiswrong piiswrong changed the title Update block.py Fix save_params warning mesage Jul 2, 2018
@szha szha merged commit 0ae38c7 into master Jul 2, 2018
@szha szha deleted the piiswrong-patch-3 branch July 2, 2018 23:25
@szha
Copy link
Member

szha commented Jul 2, 2018

@anirudh2290 you may want to cherry-pick this to 1.2 branch

anirudh2290
anirudh2290 reviewed Jul 3, 2018
View reviewed changes
python/mxnet/gluon/block.py

Save parameters to file.

filename : str
Path to file.
"""
warnings.warn("save_params is deprecated. Please use save_parameters.")
warnings.warn("save_params is deprecated. Please use save_parameters. "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not including the tutorial link in the warning ?

@srochel
Copy link
Contributor

srochel commented Jul 3, 2018

@mli - please review and confirm the changes are addressing your concerns.

@srochel
Copy link
Contributor

srochel commented Jul 3, 2018

@piiswrong Mu had requested to include link to tutorials about save/load parameters and export/import. Please review with Mu.

Roshrini pushed a commit to Roshrini/mxnet that referenced this pull request Jul 3, 2018
@piiswrong @Roshrini
Update block.py (apache#11532)
51248e7
@Roshrini Roshrini mentioned this pull request Jul 3, 2018
Merged
7 tasks
Roshrini pushed a commit to Roshrini/mxnet that referenced this pull request Jul 4, 2018
@piiswrong @Roshrini
Fix save_params warning mesage (apache#11532)
c9cb2e6
anirudh2290 pushed a commit that referenced this pull request Jul 9, 2018
@Roshrini @anirudh2290
MXNet Release-1.2.1 patch (#11548)
71fc119 
* Fix save_params warning mesage (#11532)

* Update block.py (#11540)

nit fix
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
@piiswrong @szha
Update block.py (apache#11532)
46d236f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anirudh2290 anirudh2290 anirudh2290 left review comments

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@piiswrong @szha @srochel @anirudh2290