[MXNET-531] add initial demo files #11451

lanking520 · 2018-06-28T06:42:51Z

Description

A simple demo folder contains all you need to start a Scala project with maven
@nswamy @yzhliu @andrewfayres

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
Changes are complete (i.e. I finished coding on this PR)
All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

nswamy · 2018-06-29T10:20:54Z

scala-package/demo/demo.sh

+#!/bin/bash
+CURR_DIR=$(cd $(dirname $0); pwd)
+CLASSPATH=$CLASSPATH:$CURR_DIR/target/*:$CLASSPATH:$CURR_DIR/target/classes/lib/*
+java -Xmx8G  -cp $CLASSPATH sample.HelloWorld


CPU/GPU flag like we did for examples?

nswamy · 2018-06-29T10:21:20Z

scala-package/demo/src/main/scala/sample/HelloWorld.scala

+object HelloWorld {
+  def main(args: Array[String]): Unit = {
+    println("hello World")
+    val arr = NDArray.ones(2, 3)


pass context based on CPU/GPU flag like examples?

nswamy · 2018-06-29T10:21:56Z

scala-package/demo/demo.sh

@@ -0,0 +1,4 @@
+#!/bin/bash


rename folder from demo to maven-demo?

nswamy · 2018-06-29T10:22:15Z

Also please test on linux

nswamy · 2018-07-02T22:36:54Z

scala-package/demo/pom.xml

+    <properties>
+        <mxnet.profile>osx-x86_64-cpu</mxnet.profile>
+        <mxnet.version>1.2.0</mxnet.version>
+        <scala.version>2.12.5</scala.version>


why 2.12.5 ? we support 2.11.8

nswamy · 2018-07-03T22:02:31Z

scala-package/mxnet-demo/Makefile

+	endif
+endif
+
+ifeq ($(USE_CUDA), 1)


if Linux then if CUDA
For makefile https://stackoverflow.com/questions/2741708/makefile-contains-string

nswamy · 2018-07-03T22:15:04Z

scala-package/mxnet-demo/README.md

+bash bin/demo.sh
+```
+It will load the library automatically and run the example
+### Image Classification using Inference API


If we are just copying the entire ImageClassification Example, we don't need to maintain it in two different places. I think it is redundant, lets remove this and just keep the HelloWorld
I was thinking of a more self contained code which downloads and runs the model on a fixed image.

Your thinking now come true :)

thanks, you rock 👍

nswamy · 2018-07-03T22:16:43Z

scala-package/mxnet-demo/Makefile

+# under the License.
+
+SCALA_VERSION_PROFILE := 2.11
+SCALA_VERSION := 2.11.8


Can we just use one SCALA_VERSION It should work with Scala 2.11.x

Maven cannot find a scala-library if you just fill in 2.11.

nswamy · 2018-07-03T23:39:55Z

scala-package/mxnet-demo/README.md

+```
+It will load the library automatically and run the example
+### Image Classification using Inference API
+We also provide an example to do image classification.


We also provide an example to do image classification, which downloads a ImageNet trained resnet18 model and runs inference on a cute puppy to return the classification result as
result
add what the customer should expect
You can review the complete example here

nswamy · 2018-07-03T23:45:23Z

scala-package/mxnet-demo/src/main/scala/sample/ImageClassificationExample.scala

+  */
+object ImageClassificationExample {
+
+  def downloadImage() : String = {


can you create one downloadUrl method instead of separate ?, we can move this to a TestUtils method and add hash check etc., later
downloadUrl(downloadFrom, downloadTo)

* Maven demo project

lanking520 requested a review from yzhliu as a code owner June 28, 2018 06:42

nswamy reviewed Jun 29, 2018

View reviewed changes

nswamy reviewed Jul 2, 2018

View reviewed changes

lanking520 force-pushed the scala-demo branch from 92343d5 to 383ec09 Compare July 3, 2018 00:15

lanking520 requested a review from szha as a code owner July 3, 2018 00:15

lanking520 force-pushed the scala-demo branch from 5af5563 to 2f7dd60 Compare July 3, 2018 01:07

nswamy suggested changes Jul 3, 2018

View reviewed changes

lanking520 added 8 commits July 3, 2018 16:12

add initial demo files

337eaa4

remove log 4j config

939b325

change folder name and add demo files

501ed26

add licence header

9633822

add image classification example

a8d5511

remove num_runs since we don't need it

1beb1a6

add Q & A in readme

074dbc9

simplify the demo

4be50a4

lanking520 force-pushed the scala-demo branch from 34ed36d to 4be50a4 Compare July 3, 2018 23:13

nswamy reviewed Jul 3, 2018

View reviewed changes

lanking520 added 3 commits July 3, 2018 16:53

add README and combine downloads

7984873

lazy changes

9f14e5f

Add generallized download URL method

bf097d5

nswamy approved these changes Jul 4, 2018

View reviewed changes

nswamy merged commit 9e681f2 into apache:master Jul 4, 2018

lanking520 deleted the scala-demo branch July 5, 2018 16:15

XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018

[MXNET-531] Maven demo project (apache#11451)

fd3b271

* Maven demo project

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MXNET-531] add initial demo files #11451

[MXNET-531] add initial demo files #11451

lanking520 commented Jun 28, 2018 •

edited

Loading

nswamy Jun 29, 2018

nswamy Jun 29, 2018

nswamy Jun 29, 2018

nswamy commented Jun 29, 2018

nswamy Jul 2, 2018

nswamy Jul 3, 2018

nswamy Jul 3, 2018

lanking520 Jul 3, 2018

nswamy Jul 3, 2018

nswamy Jul 3, 2018

lanking520 Jul 3, 2018

nswamy Jul 3, 2018 •

edited

Loading

nswamy Jul 3, 2018

[MXNET-531] add initial demo files #11451

[MXNET-531] add initial demo files #11451

Conversation

lanking520 commented Jun 28, 2018 • edited Loading

Description

Checklist

Essentials

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nswamy commented Jun 29, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nswamy Jul 3, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lanking520 commented Jun 28, 2018 •

edited

Loading

nswamy Jul 3, 2018 •

edited

Loading