Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Added nullptr check for LeakyRelu gamma parameter. #10886

Merged
merged 4 commits into from
May 11, 2018

Conversation

rajanksin
Copy link
Contributor

Description

It is used only for act type "prelu".
This fixes github issue:
#10885

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@rajanksin
Copy link
Contributor Author

@szha @marcoabreu Please review this PR.

@szha szha merged commit ca08c1a into apache:master May 11, 2018
@rajanksin rajanksin deleted the LeakyRelu-fix branch May 11, 2018 19:14
jinhuang415 pushed a commit to jinhuang415/incubator-mxnet that referenced this pull request May 29, 2018
* Added nullptr checks for LeakyRelu gamma parameter.
It is used only for act type "prelu".
This fixes github issue:
apache#10885

*  Added mlp_cpu, mlp, mlp_gpu tests to CI tests.

* Enabling CI tests

* Fix file name
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
* Added nullptr checks for LeakyRelu gamma parameter.
It is used only for act type "prelu".
This fixes github issue:
apache#10885

*  Added mlp_cpu, mlp, mlp_gpu tests to CI tests.

* Enabling CI tests

* Fix file name
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
* Added nullptr checks for LeakyRelu gamma parameter.
It is used only for act type "prelu".
This fixes github issue:
apache#10885

*  Added mlp_cpu, mlp, mlp_gpu tests to CI tests.

* Enabling CI tests

* Fix file name
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants