This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
fix topk nms in multibox_detection operator #10794
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in multibox_detection operator. According to operator documentation, only topk detections are kept before NMS, but the cpu operator doesn't clear the unnecessary detections after detection sort. On the other hand, the gpu operator is correctly implemented.
@zhreshold, I have already made an issue in mxnet-ssd repo.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments