Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix topk nms in multibox_detection operator #10794

Merged
merged 1 commit into from
May 4, 2018

Conversation

arcadiaphy
Copy link
Member

Description

This PR fixes a bug in multibox_detection operator. According to operator documentation, only topk detections are kept before NMS, but the cpu operator doesn't clear the unnecessary detections after detection sort. On the other hand, the gpu operator is correctly implemented.

@zhreshold, I have already made an issue in mxnet-ssd repo.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@zhreshold
Copy link
Member

The CI failed with unrelated error. Can you rebase against master and push again? @arcadiaphy

@arcadiaphy arcadiaphy force-pushed the fix_ssd branch 2 times, most recently from 124de3d to 5c06d8d Compare May 4, 2018 06:55
@arcadiaphy
Copy link
Member Author

Done, I find the last commit that has passed the CI and cherry-pick on it

@zhreshold zhreshold merged commit 38ec93c into apache:master May 4, 2018
@zhreshold
Copy link
Member

Merged, thanks for the contribution!

@arcadiaphy arcadiaphy deleted the fix_ssd branch May 5, 2018 03:30
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 7, 2018
jinhuang415 pushed a commit to jinhuang415/incubator-mxnet that referenced this pull request May 29, 2018
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants