Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-346] Fix flaky test for hard_sigmoid #10759

Merged
merged 1 commit into from
May 2, 2018
Merged

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Apr 30, 2018

Description

As title.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-346]
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Fix the too large eps for check_numeric_gradient and loosen atol

@haojin2
Copy link
Contributor Author

haojin2 commented Apr 30, 2018

@piiswrong

@marcoabreu
Copy link
Contributor

marcoabreu commented May 1, 2018

Thanks for the fix! Did you try running this test in a loop?

@haojin2
Copy link
Contributor Author

haojin2 commented May 1, 2018

I manually ran this for quite a few times already, but I'll give another try with loops, thanks for the advice!

@marcoabreu
Copy link
Contributor

@DickJC123 didn't you introduce something that allows to loop tests? Could you help us out here?

@DickJC123
Copy link
Contributor

Try something like:

$ MXNET_TEST_COUNT=10000 nosetests --logging-level=DEBUG --verbose -s test_module.py:test_op3

@marcoabreu
Copy link
Contributor

Thank you, @DickJC123! Is this variable documented somewhere?

@DickJC123
Copy link
Contributor

I owe you that. For now, documentation is at #9791

@haojin2 haojin2 force-pushed the hard_sigmoid branch 2 times, most recently from 199ee09 to 12f3734 Compare May 1, 2018 21:47
@haojin2
Copy link
Contributor Author

haojin2 commented May 2, 2018

@marcoabreu I've run this 10000 times now and it passed all of those

@marcoabreu
Copy link
Contributor

Awesome, thanks a lot!

@szha szha merged commit 65df1ee into apache:master May 2, 2018
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 7, 2018
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants