This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MXNET-346] Fix flaky test for hard_sigmoid #10759
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoabreu
approved these changes
May 1, 2018
Thanks for the fix! Did you try running this test in a loop? |
I manually ran this for quite a few times already, but I'll give another try with loops, thanks for the advice! |
@DickJC123 didn't you introduce something that allows to loop tests? Could you help us out here? |
Try something like: $ MXNET_TEST_COUNT=10000 nosetests --logging-level=DEBUG --verbose -s test_module.py:test_op3 |
Thank you, @DickJC123! Is this variable documented somewhere? |
I owe you that. For now, documentation is at #9791 |
haojin2
force-pushed
the
hard_sigmoid
branch
2 times, most recently
from
May 1, 2018 21:47
199ee09
to
12f3734
Compare
@marcoabreu I've run this 10000 times now and it passed all of those |
Awesome, thanks a lot! |
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
May 7, 2018
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As title.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes