This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-16] move dmlc-core & nnvm #10231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-haibin-lin
requested review from
cjolivier01,
marcoabreu,
sergeykolychev and
szha
as code owners
+cmake amal examples update jenkins udpate amal.py to force include 3p update amal find_source logic remove log update license move nnvm misc nnvm updates fix perl make ; update whitelist add missing license header fix launcher.py update submodule name update amal expand file
eric-haibin-lin
force-pushed
the
amal-rebase2
branch
from
d897d04 to
151503f
Compare
|
@mbaijal could you review license changes? I noticed that two files under src/nnvm didn't have the apache header |
|
@mbaijal please review the licenses and patch if necessary. |
ashokei
pushed a commit
to ashokei/incubator-mxnet
that referenced
this pull request
Mar 27, 2018
+cmake amal examples update jenkins udpate amal.py to force include 3p update amal find_source logic remove log update license move nnvm misc nnvm updates fix perl make ; update whitelist add missing license header fix launcher.py update submodule name update amal expand file
jinhuang415
pushed a commit
to jinhuang415/incubator-mxnet
that referenced
this pull request
Mar 30, 2018
+cmake amal examples update jenkins udpate amal.py to force include 3p update amal find_source logic remove log update license move nnvm misc nnvm updates fix perl make ; update whitelist add missing license header fix launcher.py update submodule name update amal expand file
mbaijal
reviewed
Mar 30, 2018
| 10. nnvm-fusion - For details, see, nnvm/plugin/nnvm-fusion/LICENSE | ||
| 8. 3rdparty/nnvm/dmlc-core - For details, see, 3rdparty/nnvm/dmlc-core/LICENSE | ||
| 9. 3rdparty/nnvm - For details, see, 3rdparty/nnvm/LICENSE | ||
| 10. nnvm-fusion - For details, see, 3rdparty/nnvm/plugin/nnvm-fusion/LICENSE |
There was a problem hiding this comment.
following the same pattern, you can add the 3rdparty path for nnvm-fusion, but I guess this should also do
There was a problem hiding this comment.
Updated in #10370
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
+cmake amal examples update jenkins udpate amal.py to force include 3p update amal find_source logic remove log update license move nnvm misc nnvm updates fix perl make ; update whitelist add missing license header fix launcher.py update submodule name update amal expand file
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
+cmake amal examples update jenkins udpate amal.py to force include 3p update amal find_source logic remove log update license move nnvm misc nnvm updates fix perl make ; update whitelist add missing license header fix launcher.py update submodule name update amal expand file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10213
Description
(Brief description on what this PR is about)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments