[MXNET-132] Change dead link in cpp-package #10210
Conversation
cpp-package/README.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| # MXNet C++ Package | |||
|
|
|||
| To build the package, please refer to <https://mxnet.incubator.apache.org/get_started/build_from_source.html#build-the-c-package>. | |||
| To build the package, please refer to [this guide](<https://github.com/apache/incubator-mxnet/blob/master/docs/install/build_from_source.md#build-the-c-package>). | |||
There was a problem hiding this comment.
I'm able to access the link before the update, which redirects to https://mxnet.incubator.apache.org/install/#build-the-c-package. Let's update the link to the new location instead of the one on github.
There was a problem hiding this comment.
sorry the link is not dead but there is no more build-c-package section
There was a problem hiding this comment.
Sorry, just realized that the anchor in the link is not working. In fact I don't think the C++ section is displayed. @thinksanky @aaronmarkham are you aware? Is this being fixed?
There was a problem hiding this comment.
#10212 I have created an issue here. Actually there is this link https://mxnet.incubator.apache.org/install/build_from_source#build-the-c-package that works. However it is not accessible from navigating within the website
cpp-package/README.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| # MXNet C++ Package | |||
|
|
|||
| To build the package, please refer to <https://mxnet.incubator.apache.org/get_started/build_from_source.html#build-the-c-package>. | |||
| To build the package, please refer to [this guide](<https://mxnet.incubator.apache.org/install/build_from_source#build-the-c-packagee>). | |||
There was a problem hiding this comment.
That package has two e's.
|
@aaronmarkham @thinksanky do we not have a broken link checker for all links on github markdown files? |
|
We run the BrokenLinkChecker on the site http://mxnet.incubator.apache.org/ recursively. Not on the markdown. I think its a great idea to have broken link checker on the git hub docs root folder itself, which can catch any external links failures. |
triggering build again, flaky test
* previous link is dead * Update README.md * Update README.md * Update README.md triggering build again, flaky test
* previous link is dead * Update README.md * Update README.md * Update README.md triggering build again, flaky test
* previous link is dead * Update README.md * Update README.md * Update README.md triggering build again, flaky test
change dead link to install guide