Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-132] Change dead link in cpp-package #10210

Merged
merged 4 commits into from
Mar 30, 2018
Merged

Conversation

ThomasDelteil
Copy link
Contributor

change dead link to install guide

@@ -1,6 +1,6 @@
# MXNet C++ Package

To build the package, please refer to <https://mxnet.incubator.apache.org/get_started/build_from_source.html#build-the-c-package>.
To build the package, please refer to [this guide](<https://github.com/apache/incubator-mxnet/blob/master/docs/install/build_from_source.md#build-the-c-package>).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm able to access the link before the update, which redirects to https://mxnet.incubator.apache.org/install/#build-the-c-package. Let's update the link to the new location instead of the one on github.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry the link is not dead but there is no more build-c-package section

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just realized that the anchor in the link is not working. In fact I don't think the C++ section is displayed. @thinksanky @aaronmarkham are you aware? Is this being fixed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#10212 I have created an issue here. Actually there is this link https://mxnet.incubator.apache.org/install/build_from_source#build-the-c-package that works. However it is not accessible from navigating within the website

@@ -1,6 +1,6 @@
# MXNet C++ Package

To build the package, please refer to <https://mxnet.incubator.apache.org/get_started/build_from_source.html#build-the-c-package>.
To build the package, please refer to [this guide](<https://mxnet.incubator.apache.org/install/build_from_source#build-the-c-packagee>).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That package has two e's.

@eric-haibin-lin
Copy link
Member

@aaronmarkham @thinksanky do we not have a broken link checker for all links on github markdown files?

@thinksanky
Copy link
Contributor

We run the BrokenLinkChecker on the site http://mxnet.incubator.apache.org/ recursively.

Not on the markdown. I think its a great idea to have broken link checker on the git hub docs root folder itself, which can catch any external links failures.

triggering build again, flaky test
@indhub indhub merged commit d07f59d into apache:master Mar 30, 2018
haojin2 pushed a commit to haojin2/incubator-mxnet that referenced this pull request Apr 2, 2018
* previous link is dead

* Update README.md

* Update README.md

* Update README.md

triggering build again, flaky test
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
* previous link is dead

* Update README.md

* Update README.md

* Update README.md

triggering build again, flaky test
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
* previous link is dead

* Update README.md

* Update README.md

* Update README.md

triggering build again, flaky test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants