Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Improve binary op kernel with MKL #16076

Open
eric-haibin-lin opened this issue Sep 2, 2019 · 5 comments
Open

Improve binary op kernel with MKL #16076

eric-haibin-lin opened this issue Sep 2, 2019 · 5 comments
Labels

Comments

@eric-haibin-lin
Copy link
Member

Binary op kernel is used for distributed kvstore at server side for gradient aggregation: https://github.com/apache/incubator-mxnet/blob/073c898e6abf415f98813acd52f11145962c96a0/src/kvstore/kvstore_dist_server.h#L732

but it is not using vectorized vsadd in MKL in its implementation:

https://github.com/apache/incubator-mxnet/blob/8df946978d68713237fd520605adc22729d241aa/src/ndarray/ndarray.cc#L890-L903

@PatricZhao @TaoLv

@mxnet-label-bot
Copy link
Contributor

Hey, this is the MXNet Label Bot.
Thank you for submitting the issue! I will try and suggest some labels so that the appropriate MXNet community members can help resolve it.
Here are my recommended label(s): Feature

@pengzhao-intel
Copy link
Contributor

@eric-haibin-lin is there any use case and background?

@eric-haibin-lin
Copy link
Member Author

Any distributed training job with parameter server uses this for gradient aggregation.

@eric-haibin-lin
Copy link
Member Author

@PatricZhao maybe the right tag is MKL instead of MKLDNN?

@eric-haibin-lin eric-haibin-lin added MKL and removed MKLDNN labels Sep 3, 2019
@bgawrych
Copy link
Contributor

bgawrych commented Jul 7, 2021

Hi @eric-haibin-lin - I assume that this feature wasn't done yet - can you provide minimum test for this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants