Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Clojure] - Add Spec Validations to the Optimizer namespace #13453

Closed
@gigasquid

Description

It would be nice to add some spec validations to the optimizer namespace https://github.com/apache/incubator-mxnet/blob/master/contrib/clojure-package/src/org/apache/clojure_mxnet/optimizer.clj

So that if a user calls a function with the incorrect arguments, it will guide them to the correct form.

Using the util/validate function as in https://github.com/apache/incubator-mxnet/blob/master/contrib/clojure-package/src/org/apache/clojure_mxnet/module.clj#L186 and the correct specs would be a great addition to the project.

Addition of unit tests to test a failing case of the spec that an exception is thrown would be great too :)

Activity

added 3 commits that reference this issue on Nov 30, 2018

apache#13453 [Clojure] - Add Spec Validations to the Optimizer namespace

apache#13453 [Clojure] - Add Spec Validations to the Optimizer namespace

apache#13453 [Clojure] - Add Spec Validations to the Optimizer namespace

added a commit that references this issue on Dec 2, 2018

#13453 [Clojure] - Add Spec Validations to the Optimizer namespace (#…

gigasquid

gigasquid commented on Dec 4, 2018

@gigasquid
MemberAuthor

Thanks for fixing this @hellonico :)

added 2 commits that reference this issue on Dec 13, 2018

apache#13453 [Clojure] - Add Spec Validations to the Optimizer namesp…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

      Participants

      @gigasquid

      Issue actions

        [Clojure] - Add Spec Validations to the Optimizer namespace · Issue #13453 · apache/mxnet