This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[Clojure] - Add Spec Validations to the Optimizer namespace #13453
Closed
Description
It would be nice to add some spec validations to the optimizer namespace https://github.com/apache/incubator-mxnet/blob/master/contrib/clojure-package/src/org/apache/clojure_mxnet/optimizer.clj
So that if a user calls a function with the incorrect arguments, it will guide them to the correct form.
Using the util/validate function as in https://github.com/apache/incubator-mxnet/blob/master/contrib/clojure-package/src/org/apache/clojure_mxnet/module.clj#L186 and the correct specs would be a great addition to the project.
Addition of unit tests to test a failing case of the spec that an exception is thrown would be great too :)
Activity
apache#13453 [Clojure] - Add Spec Validations to the Optimizer namespace
apache#13453 [Clojure] - Add Spec Validations to the Optimizer namespace
apache#13453 [Clojure] - Add Spec Validations to the Optimizer namespace
#13453 [Clojure] - Add Spec Validations to the Optimizer namespace (#…
gigasquid commentedon Dec 4, 2018
Thanks for fixing this @hellonico :)
Bumped minor version from 1.4.0 to 1.5.0 on master, updated License f…
apache#13453 [Clojure] - Add Spec Validations to the Optimizer namesp…
Bumped minor version from 1.4.0 to 1.5.0 on master, updated License f…